Commit 36f7894f authored by Nikolay Borisov's avatar Nikolay Borisov Committed by David Sterba
Browse files

btrfs: Remove redundant pair of bio_get/set in __btrfs_submit_dio_bio 



The bio is not referenced after it has been submitted and the endio is
going to consume the sole reference on successful submission. On error,
the callers of __btrfs_submit_dio_bio do invoke bio_put so we don't
leak it either.

Signed-off-by: default avatarNikolay Borisov <nborisov@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent ffc9c8dd

fs/btrfs/inode.c

+0 −3
Original line number Diff line number Diff line
@@ -8449,8 +8449,6 @@ __btrfs_submit_dio_bio(struct bio *bio, struct inode *inode, u64 file_offset, 
	if (async_submit)

		async_submit = !atomic_read(&BTRFS_I(inode)->sync_writers);



	bio_get(bio);



	if (!write) {

		ret = btrfs_bio_wq_end_io(fs_info, bio, BTRFS_WQ_ENDIO_DATA);

		if (ret)
@@ -8483,7 +8481,6 @@ __btrfs_submit_dio_bio(struct bio *bio, struct inode *inode, u64 file_offset, 
map:

	ret = btrfs_map_bio(fs_info, bio, 0, 0);

err:

	bio_put(bio);

	return ret;

}