Commit 36e4ef82 authored by Claudiu Beznea's avatar Claudiu Beznea Committed by Stephen Boyd
Browse files

clk: si5341: check return value of {devm_}kasprintf() 



{devm_}kasprintf() returns a pointer to dynamically allocated memory.
Pointer could be NULL in case allocation fails. Check pointer validity.
Identified with coccinelle (kmerr.cocci script).

Fixes: 3044a860 ("clk: Add Si5341/Si5340 driver")
Signed-off-by: default avatarClaudiu Beznea <claudiu.beznea@microchip.com>
Link: https://lore.kernel.org/r/20230530093913.1656095-5-claudiu.beznea@microchip.com


Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 2560114c

drivers/clk/clk-si5341.c

+8 −0
Original line number Diff line number Diff line
@@ -1697,6 +1697,10 @@ static int si5341_probe(struct i2c_client *client) 
	for (i = 0; i < data->num_synth; ++i) {

		synth_clock_names[i] = devm_kasprintf(&client->dev, GFP_KERNEL,

				"%s.N%u", client->dev.of_node->name, i);

		if (!synth_clock_names[i]) {

			err = -ENOMEM;

			goto free_clk_names;

		}

		init.name = synth_clock_names[i];

		data->synth[i].index = i;

		data->synth[i].data = data;
@@ -1715,6 +1719,10 @@ static int si5341_probe(struct i2c_client *client) 
	for (i = 0; i < data->num_outputs; ++i) {

		init.name = kasprintf(GFP_KERNEL, "%s.%d",

			client->dev.of_node->name, i);

		if (!init.name) {

			err = -ENOMEM;

			goto free_clk_names;

		}

		init.flags = config[i].synth_master ? CLK_SET_RATE_PARENT : 0;

		data->clk[i].index = i;

		data->clk[i].data = data;