Unverified Commit 36cb555f authored by Axel Lin's avatar Axel Lin Committed by Mark Brown
Browse files

regulator: scmi: Fix off-by-one for linear regulators .n_voltages setting 



For linear regulators, the .n_voltages is (max_uv - min_uv) / uv_step + 1.

Fixes: 0fbeae70 ("regulator: add SCMI driver")
Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Reviewed-by: default avatarCristian Marussi <cristian.marussi@arm.com>
Link: https://lore.kernel.org/r/20210521073020.1944981-1-axel.lin@ingics.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 98e48cd9

drivers/regulator/scmi-regulator.c

+1 −1
Original line number Diff line number Diff line
@@ -176,7 +176,7 @@ scmi_config_linear_regulator_mappings(struct scmi_regulator *sreg, 
		sreg->desc.uV_step =

			vinfo->levels_uv[SCMI_VOLTAGE_SEGMENT_STEP];

		sreg->desc.linear_min_sel = 0;

		sreg->desc.n_voltages = delta_uV / sreg->desc.uV_step;

		sreg->desc.n_voltages = (delta_uV / sreg->desc.uV_step) + 1;

		sreg->desc.ops = &scmi_reg_linear_ops;

	}