Commit 36bbeb33 authored Sep 06, 2021 by Colin Ian King Committed by Steve French Sep 08, 2021

ksmbd: add missing assignments to ret on ndr_read_int64 read calls



Currently there are two ndr_read_int64 calls where ret is being checked
for failure but ret is not being assigned a return value from the call.
Static analyis is reporting the checks on ret as dead code.  Fix this.

Addresses-Coverity: ("Logical dead code")
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>

parent 303fff2b

fs/ksmbd/ndr.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -275,11 +275,11 @@ int ndr_decode_dos_attr(struct ndr n, struct xattr_dos_attrib da)
	if (ret)		if (ret)
	return ret;		return ret;

	ndr_read_int64(n, NULL);		ret = ndr_read_int64(n, NULL);
	if (ret)		if (ret)
	return ret;		return ret;

	ndr_read_int64(n, NULL);		ret = ndr_read_int64(n, NULL);
	if (ret)		if (ret)
	return ret;		return ret;