Commit 36b02567 authored by Like Xu's avatar Like Xu Committed by Sean Christopherson
Browse files

KVM: svm/avic: Drop "struct kvm_x86_ops" for avic_hardware_setup() 



Even in commit 4bdec12a ("KVM: SVM: Detect X2APIC virtualization
(x2AVIC) support"), where avic_hardware_setup() was first introduced,
its only pass-in parameter "struct kvm_x86_ops *ops" is not used at all.
Clean it up a bit to avoid compiler ranting from LLVM toolchain.

Signed-off-by: default avatarLike Xu <likexu@tencent.com>
Reviewed-by: default avatarSean Christopherson <seanjc@google.com>
Link: https://lore.kernel.org/r/20221109115952.92816-1-likexu@tencent.com


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
parent 5f6015b2

arch/x86/kvm/svm/avic.c

+1 −1
Original line number Diff line number Diff line
@@ -1120,7 +1120,7 @@ void avic_vcpu_unblocking(struct kvm_vcpu *vcpu) 
 * - Hypervisor can support both xAVIC and x2AVIC in the same guest.

 * - The mode can be switched at run-time.

 */

bool avic_hardware_setup(struct kvm_x86_ops *x86_ops)

bool avic_hardware_setup(void)

{

	if (!npt_enabled)

		return false;

arch/x86/kvm/svm/svm.c

+1 −1
Original line number Diff line number Diff line
@@ -5017,7 +5017,7 @@ static __init int svm_hardware_setup(void) 
			nrips = false;

	}



	enable_apicv = avic = avic && avic_hardware_setup(&svm_x86_ops);

	enable_apicv = avic = avic && avic_hardware_setup();



	if (!enable_apicv) {

		svm_x86_ops.vcpu_blocking = NULL;

arch/x86/kvm/svm/svm.h

+1 −1
Original line number Diff line number Diff line
@@ -637,7 +637,7 @@ extern struct kvm_x86_nested_ops svm_nested_ops; 
	BIT(APICV_INHIBIT_REASON_LOGICAL_ID_ALIASED)	\

)



bool avic_hardware_setup(struct kvm_x86_ops *ops);

bool avic_hardware_setup(void);

int avic_ga_log_notifier(u32 ga_tag);

void avic_vm_destroy(struct kvm *kvm);

int avic_vm_init(struct kvm *kvm);