Commit 369cd216 authored by Kees Cook's avatar Kees Cook
Browse files

fortify: Prepare to improve strnlen() and strlen() warnings 



In order to have strlen() use fortified strnlen() internally, swap their
positions in the source. Doing this as part of later changes makes
review difficult, so reoroder it here; no code changes.

Cc: Francis Laniel <laniel_francis@privacyrequired.com>
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Reviewed-by: default avatarNick Desaulniers <ndesaulniers@google.com>
parent 072af0c6

include/linux/fortify-string.h

+11 −11
Original line number Diff line number Diff line
@@ -56,6 +56,17 @@ __FORTIFY_INLINE char *strcat(char *p, const char *q) 
	return p;

}



extern __kernel_size_t __real_strnlen(const char *, __kernel_size_t) __RENAME(strnlen);

__FORTIFY_INLINE __kernel_size_t strnlen(const char *p, __kernel_size_t maxlen)

{

	size_t p_size = __builtin_object_size(p, 1);

	__kernel_size_t ret = __real_strnlen(p, maxlen < p_size ? maxlen : p_size);



	if (p_size <= ret && maxlen != ret)

		fortify_panic(__func__);

	return ret;

}



__FORTIFY_INLINE __kernel_size_t strlen(const char *p)

{

	__kernel_size_t ret;
@@ -71,17 +82,6 @@ __FORTIFY_INLINE __kernel_size_t strlen(const char *p) 
	return ret;

}



extern __kernel_size_t __real_strnlen(const char *, __kernel_size_t) __RENAME(strnlen);

__FORTIFY_INLINE __kernel_size_t strnlen(const char *p, __kernel_size_t maxlen)

{

	size_t p_size = __builtin_object_size(p, 1);

	__kernel_size_t ret = __real_strnlen(p, maxlen < p_size ? maxlen : p_size);



	if (p_size <= ret && maxlen != ret)

		fortify_panic(__func__);

	return ret;

}



/* defined after fortified strlen to reuse it */

extern size_t __real_strlcpy(char *, const char *, size_t) __RENAME(strlcpy);

__FORTIFY_INLINE size_t strlcpy(char *p, const char *q, size_t size)