Commit 3667bbd7 authored by Sam Ravnborg's avatar Sam Ravnborg
Browse files

drm: bridge: Mark deprecated operations in drm_bridge_funcs 



drm_bridge_funcs includes several duplicated operations as atomic
variants have been added over time.
New bridge drivers shall use the atomic variants - mark the deprecated
operations to try to avoid usage in new bridge drivers.

v2:
  - Drop out-dated comment about state in mode_set (Laurent)
  - Added missing "the" in a description

Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Acked-by: default avatarMaxime Ripard <maxime@cerno.tech>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210710084240.281063-1-sam@ravnborg.org
parent b557a5f8

include/drm/drm_bridge.h

+23 −3
Original line number Diff line number Diff line
@@ -171,6 +171,11 @@ struct drm_bridge_funcs { 
	 * signals) feeding it is still running when this callback is called.

	 *

	 * The @disable callback is optional.

	 *

	 * NOTE:

	 *

	 * This is deprecated, do not use!

	 * New drivers shall use &drm_bridge_funcs.atomic_disable.

	 */

	void (*disable)(struct drm_bridge *bridge);
@@ -190,6 +195,11 @@ struct drm_bridge_funcs { 
	 * called.

	 *

	 * The @post_disable callback is optional.

	 *

	 * NOTE:

	 *

	 * This is deprecated, do not use!

	 * New drivers shall use &drm_bridge_funcs.atomic_post_disable.

	 */

	void (*post_disable)(struct drm_bridge *bridge);
@@ -215,9 +225,9 @@ struct drm_bridge_funcs { 
	 *

	 * NOTE:

	 *

	 * If a need arises to store and access modes adjusted for other

	 * locations than the connection between the CRTC and the first bridge,

	 * the DRM framework will have to be extended with DRM bridge states.

	 * This is deprecated, do not use!

	 * New drivers shall set their mode in the

	 * &drm_bridge_funcs.atomic_enable operation.

	 */

	void (*mode_set)(struct drm_bridge *bridge,

			 const struct drm_display_mode *mode,
@@ -239,6 +249,11 @@ struct drm_bridge_funcs { 
	 * there is one) when this callback is called.

	 *

	 * The @pre_enable callback is optional.

	 *

	 * NOTE:

	 *

	 * This is deprecated, do not use!

	 * New drivers shall use &drm_bridge_funcs.atomic_pre_enable.

	 */

	void (*pre_enable)(struct drm_bridge *bridge);
@@ -259,6 +274,11 @@ struct drm_bridge_funcs { 
	 * chain if there is one.

	 *

	 * The @enable callback is optional.

	 *

	 * NOTE:

	 *

	 * This is deprecated, do not use!

	 * New drivers shall use &drm_bridge_funcs.atomic_enable.

	 */

	void (*enable)(struct drm_bridge *bridge);