Commit 36476b81 authored by Maciej S. Szmigiero's avatar Maciej S. Szmigiero Committed by Takashi Iwai
Browse files

ALSA: emu10k1: Use snd_ctl_rename() to rename a control 



With the recent addition of hashed controls lookup it's not enough to just
update the control name field, the hash entries for the modified control
have to be updated too.

snd_ctl_rename() takes care of that, so use it instead of directly
modifying the control name.

Fixes: c27e1efb ("ALSA: control: Use xarray for faster lookups")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarMaciej S. Szmigiero <maciej.szmigiero@oracle.com>
Link: https://lore.kernel.org/r/38b19f019f95ee78a6e4e59d39afb9e2c3379413.1666296963.git.maciej.szmigiero@oracle.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent b51c2253

sound/pci/emu10k1/emumixer.c

+1 −1
Original line number Diff line number Diff line
@@ -1767,7 +1767,7 @@ static int rename_ctl(struct snd_card *card, const char *src, const char *dst) 
{

	struct snd_kcontrol *kctl = ctl_find(card, src);

	if (kctl) {

		strcpy(kctl->id.name, dst);

		snd_ctl_rename(card, kctl, dst);

		return 0;

	}

	return -ENOENT;