Commit 363afa3a authored by Namhyung Kim's avatar Namhyung Kim Committed by Arnaldo Carvalho de Melo
Browse files

perf synthetic-events: Don't sort the task scan result from /proc 



It should not sort the result as procfs already returns a proper
ordering of tasks.  Actually sorting the order caused problems that it
doesn't guararantee to process the main thread first.

Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Acked-by: default avatarIan Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20220701205458.985106-1-namhyung@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 5eb502b2

tools/perf/util/synthetic-events.c

+2 −2
Original line number Diff line number Diff line
@@ -754,7 +754,7 @@ static int __event__synthesize_thread(union perf_event *comm_event, 
	snprintf(filename, sizeof(filename), "%s/proc/%d/task",

		 machine->root_dir, pid);



	n = scandir(filename, &dirent, filter_task, alphasort);

	n = scandir(filename, &dirent, filter_task, NULL);

	if (n < 0)

		return n;
@@ -987,7 +987,7 @@ int perf_event__synthesize_threads(struct perf_tool *tool, 
		return 0;



	snprintf(proc_path, sizeof(proc_path), "%s/proc", machine->root_dir);

	n = scandir(proc_path, &dirent, filter_task, alphasort);

	n = scandir(proc_path, &dirent, filter_task, NULL);

	if (n < 0)

		return err;