Commit 3620a89b authored by Sean Anderson's avatar Sean Anderson Committed by Greg Kroah-Hartman
Browse files

tty: serial: uartlite: Use constants in early_uartlite_putc 



Use the constants defined at the beginning of this file instead of
integer literals when accessing registers. This makes this code easier
to read, and obviates the need for some explanatory comments.

Signed-off-by: default avatarSean Anderson <sean.anderson@seco.com>
Link: https://lore.kernel.org/r/20210826194323.3209227-1-sean.anderson@seco.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bb2853a6

drivers/tty/serial/uartlite.c

+4 −5
Original line number Diff line number Diff line
@@ -561,16 +561,15 @@ static void early_uartlite_putc(struct uart_port *port, int c) 
	 * This limit is pretty arbitrary, unless we are at about 10 baud

	 * we'll never timeout on a working UART.

	 */



	unsigned retries = 1000000;

	/* read status bit - 0x8 offset */

	while (--retries && (readl(port->membase + 8) & (1 << 3)))



	while (--retries &&

	       (readl(port->membase + ULITE_STATUS) & ULITE_STATUS_TXFULL))

		;



	/* Only attempt the iowrite if we didn't timeout */

	/* write to TX_FIFO - 0x4 offset */

	if (retries)

		writel(c & 0xff, port->membase + 4);

		writel(c & 0xff, port->membase + ULITE_TX);

}



static void early_uartlite_write(struct console *console,