Commit 3604f1e5 authored by Marek Vasut's avatar Marek Vasut
Browse files

drm: mxsfb: Reorder mxsfb_crtc_mode_set_nofb() 



Reorder mxsfb_crtc_mode_set_nofb() such that all functions which perform
register IO are called from one single location in this function. This is
a clean up. No functional change.

Reviewed-by: default avatarLucas Stach <l.stach@pengutronix.de>
Signed-off-by: default avatarMarek Vasut <marex@denx.de>
Cc: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Robby Cai <robby.cai@nxp.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Stefan Agner <stefan@agner.ch>
Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220417020800.336675-4-marex@denx.de
parent 268a06e1

drivers/gpu/drm/mxsfb/mxsfb_kms.c

+9 −9
Original line number Diff line number Diff line
@@ -282,15 +282,6 @@ static void mxsfb_crtc_mode_set_nofb(struct mxsfb_drm_private *mxsfb, 
	u32 bus_flags = mxsfb->connector->display_info.bus_flags;

	int err;



	/* Mandatory eLCDIF reset as per the Reference Manual */

	err = mxsfb_reset_block(mxsfb);

	if (err)

		return;



	mxsfb_set_formats(mxsfb, bus_format);



	clk_set_rate(mxsfb->clk, m->crtc_clock * 1000);



	if (mxsfb->bridge && mxsfb->bridge->timings)

		bus_flags = mxsfb->bridge->timings->input_bus_flags;
@@ -301,6 +292,15 @@ static void mxsfb_crtc_mode_set_nofb(struct mxsfb_drm_private *mxsfb, 
			     bus_flags);

	DRM_DEV_DEBUG_DRIVER(drm->dev, "Mode flags: 0x%08X\n", m->flags);



	/* Mandatory eLCDIF reset as per the Reference Manual */

	err = mxsfb_reset_block(mxsfb);

	if (err)

		return;



	mxsfb_set_formats(mxsfb, bus_format);



	clk_set_rate(mxsfb->clk, m->crtc_clock * 1000);



	mxsfb_set_mode(mxsfb, bus_flags);

}