Commit 35f73cca authored by Stefan Wahren's avatar Stefan Wahren Committed by Stephen Boyd
Browse files

clk: bcm: rpi: Fix error handling of raspberrypi_fw_get_rate 



The function raspberrypi_fw_get_rate (e.g. used for the recalc_rate
hook) can fail to get the clock rate from the firmware. In this case
we cannot return a signed error value, which would be casted to
unsigned long. Fix this by returning 0 instead.

Signed-off-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
Link: https://lore.kernel.org/r/20220625083643.4012-1-stefan.wahren@i2se.com


Fixes: 4e85e535 ("clk: bcm283x: add driver interfacing with Raspberry Pi's firmware")
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 4b592061

drivers/clk/bcm/clk-raspberrypi.c

+1 −1
Original line number Diff line number Diff line
@@ -203,7 +203,7 @@ static unsigned long raspberrypi_fw_get_rate(struct clk_hw *hw, 
	ret = raspberrypi_clock_property(rpi->firmware, data,

					 RPI_FIRMWARE_GET_CLOCK_RATE, &val);

	if (ret)

		return ret;

		return 0;



	return val;

}