Commit 35f165f0 authored by Vikash Chandola's avatar Vikash Chandola Committed by Guenter Roeck
Browse files

hwmon: (pmbus) Clear pmbus fault/warning bits after read 



Almost all fault/warning bits in pmbus status registers remain set even
after fault/warning condition are removed. As per pmbus specification
these faults must be cleared by user.
Modify hwmon behavior to clear fault/warning bit after fetching data if
fault/warning bit was set. This allows to get fresh data in next read.

Signed-off-by: default avatarVikash Chandola <vikash.chandola@linux.intel.com>
Link: https://lore.kernel.org/r/20220222131253.2426834-1-vikash.chandola@linux.intel.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 1b5f517c

drivers/hwmon/pmbus/pmbus_core.c

+5 −0
Original line number Diff line number Diff line
@@ -911,6 +911,11 @@ static int pmbus_get_boolean(struct i2c_client *client, struct pmbus_boolean *b, 
		pmbus_update_sensor_data(client, s2);



	regval = status & mask;

	if (regval) {

		ret = pmbus_write_byte_data(client, page, reg, regval);

		if (ret)

			goto unlock;

	}

	if (s1 && s2) {

		s64 v1, v2;