Commit 35d7b72a authored by Srinivas Neeli's avatar Srinivas Neeli Committed by Bartosz Golaszewski
Browse files

gpio: zynq: Check return value of irq_get_irq_data 



In two different instances the return value of "irq_get_irq_data"
API was neither captured nor checked.
Fixed it by capturing the return value and then checking for any error.

Addresses-Coverity: "returned_null"
Signed-off-by: default avatarSrinivas Neeli <srinivas.neeli@xilinx.com>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent a51b2fb9

drivers/gpio/gpio-zynq.c

+10 −0
Original line number Diff line number Diff line
@@ -736,6 +736,11 @@ static int __maybe_unused zynq_gpio_suspend(struct device *dev) 
	struct zynq_gpio *gpio = dev_get_drvdata(dev);

	struct irq_data *data = irq_get_irq_data(gpio->irq);



	if (!data) {

		dev_err(dev, "irq_get_irq_data() failed\n");

		return -EINVAL;

	}



	if (!device_may_wakeup(dev))

		disable_irq(gpio->irq);
@@ -753,6 +758,11 @@ static int __maybe_unused zynq_gpio_resume(struct device *dev) 
	struct irq_data *data = irq_get_irq_data(gpio->irq);

	int ret;



	if (!data) {

		dev_err(dev, "irq_get_irq_data() failed\n");

		return -EINVAL;

	}



	if (!device_may_wakeup(dev))

		enable_irq(gpio->irq);