Commit 35ad0d90 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

usb: misc: brcmstb-usb-pinmap: Fix an IS_ERR() vs NULL check 



The devm_ioremap() function doesn't return error pointers, it returns
NULL on error.

Fixes: 517c4c44 ("usb: Add driver to allow any GPIO to be used for 7211 USB signals")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20201102075655.GA4163205@mwanda


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8fba56b4

drivers/usb/misc/brcmstb-usb-pinmap.c

+2 −2
Original line number Diff line number Diff line
@@ -277,8 +277,8 @@ static int __init brcmstb_usb_pinmap_probe(struct platform_device *pdev) 
	pdata->out_pins = (struct out_pin *)(pdata->in_pins + in_count);



	pdata->regs = devm_ioremap(&pdev->dev, r->start, resource_size(r));

	if (IS_ERR(pdata->regs))

		return PTR_ERR(pdata->regs);

	if (!pdata->regs)

		return -ENOMEM;

	platform_set_drvdata(pdev, pdata);



	err = parse_pins(&pdev->dev, dn, pdata);