Commit 35a3bffe authored by Chengming Zhou's avatar Chengming Zhou Committed by Peng Zhang
Browse files

mm/slub: remove unused parameter in next_freelist_entry() 

mainline inclusion
from mainline-v6.9-rc1
commit c63349fc4a2d10f5d1b5ee805cb639ee88fd6e4a
category: performance
bugzilla: https://gitee.com/openeuler/kernel/issues/I9CSFJ
CVE: NA

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c63349fc4a2d10f5d1b5ee805cb639ee88fd6e4a



--------------------------------

The parameter "struct slab *slab" is unused in next_freelist_entry(),
so just remove it.

Acked-by: default avatarChristoph Lameter (Ampere) <cl@linux.com>
Reviewed-by: default avatarVlastimil Babka <vbabka@suse.cz>
Signed-off-by: default avatarChengming Zhou <zhouchengming@bytedance.com>
Signed-off-by: default avatarVlastimil Babka <vbabka@suse.cz>
Signed-off-by: default avatarZhangPeng <zhangpeng362@huawei.com>
parent c5b419c2

mm/slub.c

+3 −4
Original line number Diff line number Diff line
@@ -1941,7 +1941,7 @@ static void __init init_freelist_randomization(void) 
}



/* Get the next entry on the pre-computed freelist randomized */

static void *next_freelist_entry(struct kmem_cache *s, struct slab *slab,

static void *next_freelist_entry(struct kmem_cache *s,

				unsigned long *pos, void *start,

				unsigned long page_limit,

				unsigned long freelist_count)
@@ -1980,13 +1980,12 @@ static bool shuffle_freelist(struct kmem_cache *s, struct slab *slab) 
	start = fixup_red_left(s, slab_address(slab));



	/* First entry is used as the base of the freelist */

	cur = next_freelist_entry(s, slab, &pos, start, page_limit,

				freelist_count);

	cur = next_freelist_entry(s, &pos, start, page_limit, freelist_count);

	cur = setup_object(s, cur);

	slab->freelist = cur;



	for (idx = 1; idx < slab->objects; idx++) {

		next = next_freelist_entry(s, slab, &pos, start, page_limit,

		next = next_freelist_entry(s, &pos, start, page_limit,

			freelist_count);

		next = setup_object(s, next);

		set_freepointer(s, cur, next);