Unverified Commit 359f5b0d authored by Li Lanzhe's avatar Li Lanzhe Committed by Mark Brown
Browse files

spi: spi-rockchip: Fix missing unwind goto in rockchip_sfc_probe() 



If devm_request_irq() fails, then we are directly return 'ret' without
clk_disable_unprepare(sfc->clk) and clk_disable_unprepare(sfc->hclk).

Fix this by changing direct return to a goto 'err_irq'.

Fixes: 0b89fc0a ("spi: rockchip-sfc: add rockchip serial flash controller")
Signed-off-by: default avatarLi Lanzhe <u202212060@hust.edu.cn>
Reviewed-by: default avatarDongliang Mu <dzm91@hust.edu.cn>
Link: https://lore.kernel.org/r/20230419115030.6029-1-u202212060@hust.edu.cn


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent e8d018dd

drivers/spi/spi-rockchip-sfc.c

+1 −1
Original line number Diff line number Diff line
@@ -632,7 +632,7 @@ static int rockchip_sfc_probe(struct platform_device *pdev) 
	if (ret) {

		dev_err(dev, "Failed to request irq\n");



		return ret;

		goto err_irq;

	}



	ret = rockchip_sfc_init(sfc);