Unverified Commit 357a1ebd authored by Mark Brown's avatar Mark Brown
Browse files

regmap: Add test to make sure we don't sync to read only registers 



Ensure that a read only value in the register cache does not result in a
write during regcache_sync().

Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20230613-regmap-kunit-read-write-v1-3-2db337c52827@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent a07bff40

drivers/base/regmap/regmap-kunit.c

+42 −0
Original line number Diff line number Diff line
@@ -680,6 +680,47 @@ static void cache_sync_defaults(struct kunit *test) 
	regmap_exit(map);

}



static void cache_sync_readonly(struct kunit *test)

{

	struct regcache_types *t = (struct regcache_types *)test->param_value;

	struct regmap *map;

	struct regmap_config config;

	struct regmap_ram_data *data;

	unsigned int val;

	int i;



	config = test_regmap_config;

	config.cache_type = t->type;

	config.writeable_reg = reg_5_false;



	map = gen_regmap(&config, &data);

	KUNIT_ASSERT_FALSE(test, IS_ERR(map));

	if (IS_ERR(map))

		return;



	/* Read all registers to fill the cache */

	for (i = 0; i < BLOCK_TEST_SIZE; i++)

		KUNIT_EXPECT_EQ(test, 0, regmap_read(map, i, &val));



	/* Change the value of all registers, readonly should fail */

	get_random_bytes(&val, sizeof(val));

	regcache_cache_only(map, true);

	for (i = 0; i < BLOCK_TEST_SIZE; i++)

		KUNIT_EXPECT_EQ(test, i != 5, regmap_write(map, i, val) == 0);

	regcache_cache_only(map, false);



	/* Resync */

	for (i = 0; i < BLOCK_TEST_SIZE; i++)

		data->written[i] = false;

	KUNIT_EXPECT_EQ(test, 0, regcache_sync(map));



	/* Did that match what we see on the device? */

	for (i = 0; i < BLOCK_TEST_SIZE; i++)

		KUNIT_EXPECT_EQ(test, i != 5, data->written[i]);



	regmap_exit(map);

}



static void cache_sync_patch(struct kunit *test)

{

	struct regcache_types *t = (struct regcache_types *)test->param_value;
@@ -1119,6 +1160,7 @@ static struct kunit_case regmap_test_cases[] = { 
	KUNIT_CASE_PARAM(cache_bypass, real_cache_types_gen_params),

	KUNIT_CASE_PARAM(cache_sync, real_cache_types_gen_params),

	KUNIT_CASE_PARAM(cache_sync_defaults, real_cache_types_gen_params),

	KUNIT_CASE_PARAM(cache_sync_readonly, real_cache_types_gen_params),

	KUNIT_CASE_PARAM(cache_sync_patch, real_cache_types_gen_params),

	KUNIT_CASE_PARAM(cache_drop, sparse_cache_types_gen_params),