Unverified Commit 3577a8a0 authored by Stephen Kitt's avatar Stephen Kitt Committed by Mark Brown
Browse files

ASoC: pcm186x: use i2c_match_id and simple i2c probe 



As part of the ongoing i2c transition to the simple probe
("probe_new"), this patch uses i2c_match_id to retrieve the
driver_data for the probed device. The id parameter is thus no longer
necessary and the simple probe can be used instead.

The i2c id table is moved up before the probe function, as suggested
by Wolfram Sang.

Signed-off-by: default avatarStephen Kitt <steve@sk2.org>
Link: https://lore.kernel.org/r/20220415160613.148882-5-steve@sk2.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 4ac8ebb6

sound/soc/codecs/pcm186x-i2c.c

+12 −12
Original line number Diff line number Diff line
@@ -22,9 +22,18 @@ static const struct of_device_id pcm186x_of_match[] = { 
};

MODULE_DEVICE_TABLE(of, pcm186x_of_match);



static int pcm186x_i2c_probe(struct i2c_client *i2c,

			     const struct i2c_device_id *id)

static const struct i2c_device_id pcm186x_i2c_id[] = {

	{ "pcm1862", PCM1862 },

	{ "pcm1863", PCM1863 },

	{ "pcm1864", PCM1864 },

	{ "pcm1865", PCM1865 },

	{ }

};

MODULE_DEVICE_TABLE(i2c, pcm186x_i2c_id);



static int pcm186x_i2c_probe(struct i2c_client *i2c)

{

	const struct i2c_device_id *id = i2c_match_id(pcm186x_i2c_id, i2c);

	const enum pcm186x_type type = (enum pcm186x_type)id->driver_data;

	int irq = i2c->irq;

	struct regmap *regmap;
@@ -36,17 +45,8 @@ static int pcm186x_i2c_probe(struct i2c_client *i2c, 
	return pcm186x_probe(&i2c->dev, type, irq, regmap);

}



static const struct i2c_device_id pcm186x_i2c_id[] = {

	{ "pcm1862", PCM1862 },

	{ "pcm1863", PCM1863 },

	{ "pcm1864", PCM1864 },

	{ "pcm1865", PCM1865 },

	{ }

};

MODULE_DEVICE_TABLE(i2c, pcm186x_i2c_id);



static struct i2c_driver pcm186x_i2c_driver = {

	.probe		= pcm186x_i2c_probe,

	.probe_new	= pcm186x_i2c_probe,

	.id_table	= pcm186x_i2c_id,

	.driver		= {

		.name	= "pcm186x",