Commit 356184fb authored Oct 19, 2020 by Randy Dunlap Committed by David S. Miller Feb 18, 2021

sparc: make xchg() into a statement expression



Fix several of the same warning by using a GCC statement expression
(extension):

../arch/sparc/include/asm/cmpxchg_32.h:28:22: warning: value computed is not used [-Wunused-value]
   28 | #define xchg(ptr,x) ((__typeof__(*(ptr)))__xchg((unsigned long)(x),(ptr),sizeof(*(ptr))))

Passes sparc32 allmodconfig with no xchg warnings.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 147d8622

arch/sparc/include/asm/cmpxchg_32.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -25,7 +25,7 @@ static inline unsigned long __xchg(unsigned long x, __volatile__ void * ptr, int
		return x;
		}

		#define xchg(ptr,x) ((__typeof__((ptr)))__xchg((unsigned long)(x),(ptr),sizeof((ptr))))
		#define xchg(ptr,x) ({(__typeof__((ptr)))__xchg((unsigned long)(x),(ptr),sizeof((ptr)));})

		/* Emulate cmpxchg() the same way we emulate atomics,
		* by hashing the object address and indexing into an array