Commit 35503ce1 authored by Jiri Olsa's avatar Jiri Olsa Committed by Arnaldo Carvalho de Melo
Browse files

perf script: Skip dummy event attr check 



Hongtao Yu reported problem when displaying uregs in perf script
for system wide perf.data:

  # perf script -F uregs | head -10
  Samples for 'dummy:HG' event do not have UREGS attribute set. Cannot print 'uregs' field.

The problem is the extra dummy event added for system wide,
which does not have proper sample_type setup.

Skipping attr check completely for dummy event as suggested
by Namhyung, because it does not have any samples anyway.

Reported-by: default avatarHongtao Yu <hoy@fb.com>
Suggested-by: default avatarNamhyung Kim <namhyung@kernel.org>
Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
Acked-by: default avatarIan Rogers <irogers@google.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20220831124041.219925-1-jolsa@kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 3f5df3ac

tools/perf/builtin-script.c

+2 −0
Original line number Diff line number Diff line
@@ -566,6 +566,8 @@ static struct evsel *find_first_output_type(struct evlist *evlist, 
	struct evsel *evsel;



	evlist__for_each_entry(evlist, evsel) {

		if (evsel__is_dummy_event(evsel))

			continue;

		if (output_type(evsel->core.attr.type) == (int)type)

			return evsel;

	}