Commit 35471138 authored Mar 21, 2021 by Hans de Goede

platform/x86: dell-wmi-sysman: Cleanup create_attributes_level_sysfs_files()



Cleanup create_attributes_level_sysfs_files():

1. There is no need to call sysfs_remove_file() on error, sysman_init()
will already call release_attributes_data() on failure which already does
this.

2. There is no need for the pr_debug() calls sysfs_create_file() should
never fail and if it does it will already complain about the problem
itself.

Fixes: e8a60aa7 ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems")
Cc: Divya Bharathi <Divya_Bharathi@dell.com>
Cc: Mario Limonciello <mario.limonciello@dell.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210321115901.35072-8-hdegoede@redhat.com

parent 32418dd5

drivers/platform/x86/dell/dell-wmi-sysman/sysman.c

+7 −9

Original line number	Diff line number	Diff line
		@@ -210,19 +210,17 @@ static struct kobj_attribute pending_reboot = __ATTR_RO(pending_reboot);
		*/
		static int create_attributes_level_sysfs_files(void)
		{
		int ret = sysfs_create_file(&wmi_priv.main_dir_kset->kobj, &reset_bios.attr);
		int ret;

		if (ret) {
		pr_debug("could not create reset_bios file\n");
		ret = sysfs_create_file(&wmi_priv.main_dir_kset->kobj, &reset_bios.attr);
		if (ret)
		return ret;
		}

		ret = sysfs_create_file(&wmi_priv.main_dir_kset->kobj, &pending_reboot.attr);
		if (ret) {
		pr_debug("could not create changing_pending_reboot file\n");
		sysfs_remove_file(&wmi_priv.main_dir_kset->kobj, &reset_bios.attr);
		}
		if (ret)
		return ret;

		return 0;
		}

		static ssize_t wmi_sysman_attr_show(struct kobject kobj, struct attribute attr,