Unverified Commit 352e1eb1 authored by Long Wang's avatar Long Wang Committed by Mark Brown
Browse files

ASoC: max98373: change power down sequence for smart amp 



In order to avoid pop noise which occurs when switching
device from speaker to headphone, the amplifier should
power down first when stopping playback.

Signed-off-by: default avatarLong Wang <long.wang@analog.com>
Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarRander Wang <rander.wang@intel.com>
Link: https://lore.kernel.org/r/20230406154535.18205-1-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 0b186bb0

sound/soc/codecs/max98373.c

+2 −2
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ static int max98373_dac_event(struct snd_soc_dapm_widget *w, 
			MAX98373_GLOBAL_EN_MASK, 1);

		usleep_range(30000, 31000);

		break;

	case SND_SOC_DAPM_POST_PMD:

	case SND_SOC_DAPM_PRE_PMD:

		regmap_update_bits(max98373->regmap,

			MAX98373_R20FF_GLOBAL_SHDN,

			MAX98373_GLOBAL_EN_MASK, 0);
@@ -64,7 +64,7 @@ static const struct snd_kcontrol_new max98373_spkfb_control = 
static const struct snd_soc_dapm_widget max98373_dapm_widgets[] = {

SND_SOC_DAPM_DAC_E("Amp Enable", "HiFi Playback",

	MAX98373_R202B_PCM_RX_EN, 0, 0, max98373_dac_event,

	SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_POST_PMD),

	SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_PRE_PMD),

SND_SOC_DAPM_MUX("DAI Sel Mux", SND_SOC_NOPM, 0, 0,

	&max98373_dai_controls),

SND_SOC_DAPM_OUTPUT("BE_OUT"),