Commit 3512fc1e authored May 04, 2022 by Dave Chinner Committed by Dave Chinner May 04, 2022

xfs: whiteouts release intents that are not in the AIL



When we release an intent that a whiteout applies to, it will not
have been committed to the journal and so won't be in the AIL. Hence
when we drop the last reference to the intent, we do not want to try
to remove it from the AIL as that will trigger a filesystem
shutdown. Hence make the removal of intents from the AIL conditional
on them actually being in the AIL so we do the correct thing.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Dave Chinner <david@fromorbit.com>

parent c23ab603

fs/xfs/xfs_bmap_item.c

+5 −4

Original line number	Diff line number	Diff line
		@@ -55,11 +55,12 @@ xfs_bui_release(
		struct xfs_bui_log_item *buip)
		{
		ASSERT(atomic_read(&buip->bui_refcount) > 0);
		if (atomic_dec_and_test(&buip->bui_refcount)) {
		xfs_trans_ail_delete(&buip->bui_item, SHUTDOWN_LOG_IO_ERROR);
		if (!atomic_dec_and_test(&buip->bui_refcount))
		return;

		xfs_trans_ail_delete(&buip->bui_item, 0);
		xfs_bui_item_free(buip);
		}
		}


		STATIC void

fs/xfs/xfs_extfree_item.c

+5 −4

Original line number	Diff line number	Diff line
		@@ -58,11 +58,12 @@ xfs_efi_release(
		struct xfs_efi_log_item *efip)
		{
		ASSERT(atomic_read(&efip->efi_refcount) > 0);
		if (atomic_dec_and_test(&efip->efi_refcount)) {
		xfs_trans_ail_delete(&efip->efi_item, SHUTDOWN_LOG_IO_ERROR);
		if (!atomic_dec_and_test(&efip->efi_refcount))
		return;

		xfs_trans_ail_delete(&efip->efi_item, 0);
		xfs_efi_item_free(efip);
		}
		}

		/*
		* This returns the number of iovecs needed to log the given efi item.

fs/xfs/xfs_refcount_item.c

+5 −4

Original line number	Diff line number	Diff line
		@@ -54,11 +54,12 @@ xfs_cui_release(
		struct xfs_cui_log_item *cuip)
		{
		ASSERT(atomic_read(&cuip->cui_refcount) > 0);
		if (atomic_dec_and_test(&cuip->cui_refcount)) {
		xfs_trans_ail_delete(&cuip->cui_item, SHUTDOWN_LOG_IO_ERROR);
		if (!atomic_dec_and_test(&cuip->cui_refcount))
		return;

		xfs_trans_ail_delete(&cuip->cui_item, 0);
		xfs_cui_item_free(cuip);
		}
		}


		STATIC void

fs/xfs/xfs_rmap_item.c

+5 −4

Original line number	Diff line number	Diff line
		@@ -54,11 +54,12 @@ xfs_rui_release(
		struct xfs_rui_log_item *ruip)
		{
		ASSERT(atomic_read(&ruip->rui_refcount) > 0);
		if (atomic_dec_and_test(&ruip->rui_refcount)) {
		xfs_trans_ail_delete(&ruip->rui_item, SHUTDOWN_LOG_IO_ERROR);
		if (!atomic_dec_and_test(&ruip->rui_refcount))
		return;

		xfs_trans_ail_delete(&ruip->rui_item, 0);
		xfs_rui_item_free(ruip);
		}
		}

		STATIC void
		xfs_rui_item_size(