Commit 350994bf authored by Peter Zijlstra's avatar Peter Zijlstra
Browse files

objtool: Re-arrange validate_functions() 



In preparation to adding a vmlinux.o specific pass, rearrange some
code. No functional changes intended.

Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarMiroslav Benes <mbenes@suse.cz>
Acked-by: default avatarJosh Poimboeuf <jpoimboe@redhat.com>
Link: https://lkml.kernel.org/r/20200324160924.924304616@infradead.org
parent 74b873e4

tools/objtool/check.c

+30 −22
Original line number Diff line number Diff line
@@ -2395,9 +2395,8 @@ static bool ignore_unreachable_insn(struct instruction *insn) 
	return false;

}



static int validate_functions(struct objtool_file *file)

static int validate_section(struct objtool_file *file, struct section *sec)

{

	struct section *sec;

	struct symbol *func;

	struct instruction *insn;

	struct insn_state state;
@@ -2410,7 +2409,6 @@ static int validate_functions(struct objtool_file *file) 
	       CFI_NUM_REGS * sizeof(struct cfi_reg));

	state.stack_size = initial_func_cfi.cfa.offset;



	for_each_sec(file, sec) {

	list_for_each_entry(func, &sec->symbol_list, list) {

		if (func->type != STT_FUNC)

			continue;
@@ -2435,8 +2433,18 @@ static int validate_functions(struct objtool_file *file) 
			BT_FUNC("<=== (func)", insn);

		warnings += ret;

	}



	return warnings;

}



static int validate_functions(struct objtool_file *file)

{

	struct section *sec;

	int warnings = 0;



	for_each_sec(file, sec)

		warnings += validate_section(file, sec);



	return warnings;

}