Commit 34f5e9b9 authored by Miaohe Lin's avatar Miaohe Lin Committed by Linus Torvalds
Browse files

mm/migrate.c: fix potential indeterminate pte entry in migrate_vma_insert_page() 

If the zone device page does not belong to un-addressable device memory,
the variable entry will be uninitialized and lead to indeterminate pte
entry ultimately.  Fix this unexpected case and warn about it.

Link: https://lkml.kernel.org/r/20210325131524.48181-4-linmiaohe@huawei.com


Fixes: df6ad698 ("mm/device-public-memory: device memory cache coherent with CPU")
Signed-off-by: default avatarMiaohe Lin <linmiaohe@huawei.com>
Reviewed-by: default avatarDavid Hildenbrand <david@redhat.com>
Cc: Alistair Popple <apopple@nvidia.com>
Cc: Jerome Glisse <jglisse@redhat.com>
Cc: Rafael Aquini <aquini@redhat.com>
Cc: Yang Shi <shy828301@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent a04840c6

mm/migrate.c

+7 −0
Original line number Diff line number Diff line
@@ -2947,6 +2947,13 @@ static void migrate_vma_insert_page(struct migrate_vma *migrate, 


			swp_entry = make_device_private_entry(page, vma->vm_flags & VM_WRITE);

			entry = swp_entry_to_pte(swp_entry);

		} else {

			/*

			 * For now we only support migrating to un-addressable

			 * device memory.

			 */

			pr_warn_once("Unsupported ZONE_DEVICE page type.\n");

			goto abort;

		}

	} else {

		entry = mk_pte(page, vma->vm_page_prot);