Commit 34eb5ccf authored by Jason Yan's avatar Jason Yan Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Remove unneeded variable 'rval' 

This addresses the following coccinelle warning:

drivers/scsi/qla2xxx/qla_init.c:7112:5-9: Unneeded variable: "rval".
Return "QLA_SUCCESS" on line 7115

Link: https://lore.kernel.org/r/20200911091021.2937708-1-yanaijie@huawei.com


Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Reviewed-by: default avatarHimanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: default avatarJason Yan <yanaijie@huawei.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 247f9944

drivers/scsi/qla2xxx/qla_init.c

+2 −3
Original line number Diff line number Diff line
@@ -7119,10 +7119,9 @@ qla24xx_reset_adapter(scsi_qla_host_t *vha) 
	unsigned long flags = 0;

	struct qla_hw_data *ha = vha->hw;

	struct device_reg_24xx __iomem *reg = &ha->iobase->isp24;

	int rval = QLA_SUCCESS;



	if (IS_P3P_TYPE(ha))

		return rval;

		return QLA_SUCCESS;



	vha->flags.online = 0;

	ha->isp_ops->disable_intrs(ha);
@@ -7137,7 +7136,7 @@ qla24xx_reset_adapter(scsi_qla_host_t *vha) 
	if (IS_NOPOLLING_TYPE(ha))

		ha->isp_ops->enable_intrs(ha);



	return rval;

	return QLA_SUCCESS;

}



/* On sparc systems, obtain port and node WWN from firmware