Commit 34e3d3c9 authored by Jacopo Mondi's avatar Jacopo Mondi Committed by Mauro Carvalho Chehab
Browse files

media: i2c: imx219: Simplify code handling in s_fmt 



The imx219_set_pad_format() function adjusts the media bus code provided
through the v4l2_subdev_format parameter to a media bus code known
to be supported by the sensor.

The same exact operation is performed by the imx219_get_format_code()
function which called by imx219_update_pad_format(), which is in the
imx219_set_pad_format() call path.

Remove the duplicated operation and simplify imx219_set_pad_format().

Signed-off-by: default avatarJacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 7319d570

drivers/media/i2c/imx219.c

+1 −9
Original line number Diff line number Diff line
@@ -750,21 +750,13 @@ static int imx219_set_pad_format(struct v4l2_subdev *sd, 
	const struct imx219_mode *mode;

	int exposure_max, exposure_def, hblank;

	struct v4l2_mbus_framefmt *format;

	unsigned int i;



	for (i = 0; i < ARRAY_SIZE(imx219_mbus_formats); i++)

		if (imx219_mbus_formats[i] == fmt->format.code)

			break;

	if (i >= ARRAY_SIZE(imx219_mbus_formats))

		i = 0;



	mode = v4l2_find_nearest_size(supported_modes,

				      ARRAY_SIZE(supported_modes),

				      width, height,

				      fmt->format.width, fmt->format.height);



	imx219_update_pad_format(imx219, mode, &fmt->format,

				 imx219_mbus_formats[i]);

	imx219_update_pad_format(imx219, mode, &fmt->format, fmt->format.code);

	format = v4l2_subdev_get_pad_format(sd, sd_state, 0);



	if (imx219->mode == mode && format->code == fmt->format.code)