Commit 34de8e6e authored by Pu Lehui's avatar Pu Lehui Committed by Daniel Borkmann
Browse files

bpftool: Fix NULL pointer dereference when pin {PROG, MAP, LINK} without FILE 



When using bpftool to pin {PROG, MAP, LINK} without FILE,
segmentation fault will occur. The reson is that the lack
of FILE will cause strlen to trigger NULL pointer dereference.
The corresponding stacktrace is shown below:

do_pin
  do_pin_any
    do_pin_fd
      mount_bpffs_for_pin
        strlen(name) <- NULL pointer dereference

Fix it by adding validation to the common process.

Fixes: 75a1e792 ("tools: bpftool: Allow all prog/map handles for pinning objects")
Signed-off-by: default avatarPu Lehui <pulehui@huawei.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Reviewed-by: default avatarQuentin Monnet <quentin@isovalent.com>
Link: https://lore.kernel.org/bpf/20221102084034.3342995-1-pulehui@huaweicloud.com
parent 8ec95b94

tools/bpf/bpftool/common.c

+3 −0
Original line number Diff line number Diff line
@@ -300,6 +300,9 @@ int do_pin_any(int argc, char **argv, int (*get_fd)(int *, char ***)) 
	int err;

	int fd;



	if (!REQ_ARGS(3))

		return -EINVAL;



	fd = get_fd(&argc, &argv);

	if (fd < 0)

		return fd;