Commit 34d1eb0e authored by Josef Bacik's avatar Josef Bacik Committed by David Sterba
Browse files

btrfs: don't clear ret in btrfs_start_dirty_block_groups 



If we fail to update a block group item in the loop we'll break, however
we'll do btrfs_run_delayed_refs and lose our error value in ret, and
thus not clean up properly.  Fix this by only running the delayed refs
if there was no failure.

CC: stable@vger.kernel.org # 4.4+
Reviewed-by: default avatarQu Wenruo <wqu@suse.com>
Reviewed-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: default avatarJosef Bacik <josef@toxicpanda.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent fb286100

fs/btrfs/block-group.c

+2 −1
Original line number Diff line number Diff line
@@ -2669,6 +2669,7 @@ int btrfs_start_dirty_block_groups(struct btrfs_trans_handle *trans) 
	 * Go through delayed refs for all the stuff we've just kicked off

	 * and then loop back (just once)

	 */

	if (!ret)

		ret = btrfs_run_delayed_refs(trans, 0);

	if (!ret && loops == 0) {

		loops++;