Commit 34c7f50f authored by Julian Wiedmann's avatar Julian Wiedmann Committed by Jakub Kicinski
Browse files

s390/qeth: make af_iucv TX notification call more robust 



Calling into socket code is ugly already, at least check whether we are
dealing with the expected sk_family. Only looking at skb->protocol is
bound to cause troubles (consider eg. af_packet).

Fixes: b3332930 ("qeth: add support for af_iucv HiperSockets transport")
Signed-off-by: default avatarJulian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 0d0e2b53

drivers/s390/net/qeth_core_main.c

+2 −1
Original line number Diff line number Diff line
@@ -33,6 +33,7 @@ 


#include <net/iucv/af_iucv.h>

#include <net/dsfield.h>

#include <net/sock.h>



#include <asm/ebcdic.h>

#include <asm/chpid.h>
@@ -1405,7 +1406,7 @@ static void qeth_notify_skbs(struct qeth_qdio_out_q *q, 
	skb_queue_walk(&buf->skb_list, skb) {

		QETH_CARD_TEXT_(q->card, 5, "skbn%d", notification);

		QETH_CARD_TEXT_(q->card, 5, "%lx", (long) skb);

		if (skb->protocol == htons(ETH_P_AF_IUCV) && skb->sk)

		if (skb->sk && skb->sk->sk_family == PF_IUCV)

			iucv_sk(skb->sk)->sk_txnotify(skb, notification);

	}

}