Commit 34ba3657 authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Jiri Kosina
Browse files

HID: i2c-hid: switch to standard debugging APIs 



Instead of implementing a custom form of dynamic debugging we can use
the standard debugging APIs. If the kernel is built with
CONFIG_DYNAMIC_DEBUG this will be more discoverable and featureful.

Also the previous module parameter "debug" is read-only so it can't
actually be enabled.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent d264dd3b

drivers/hid/i2c-hid/i2c-hid-core.c

+1 −10
Original line number Diff line number Diff line
@@ -67,16 +67,7 @@ 
#define I2C_HID_PWR_ON		0x00

#define I2C_HID_PWR_SLEEP	0x01



/* debug option */

static bool debug;

module_param(debug, bool, 0444);

MODULE_PARM_DESC(debug, "print a lot of debug information");



#define i2c_hid_dbg(ihid, fmt, arg...)					  \

do {									  \

	if (debug)							  \

		dev_printk(KERN_DEBUG, &(ihid)->client->dev, fmt, ##arg); \

} while (0)

#define i2c_hid_dbg(ihid, ...) dev_dbg(&(ihid)->client->dev, __VA_ARGS__)



struct i2c_hid_desc {

	__le16 wHIDDescLength;