Commit 34ac17ec authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

ethtool: use ethnl_parse_header_dev_put() 



It seems I missed that most ethnl_parse_header_dev_get() callers
declare an on-stack struct ethnl_req_info, and that they simply call
dev_put(req_info.dev) when about to return.

Add ethnl_parse_header_dev_put() helper to properly untrack
reference taken by ethnl_parse_header_dev_get().

Fixes: e4b89540 ("netlink: add net device refcount tracker to struct ethnl_req_info")
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6cf7a1ac

net/ethtool/cabletest.c

+2 −2
Original line number Diff line number Diff line
@@ -96,7 +96,7 @@ int ethnl_act_cable_test(struct sk_buff *skb, struct genl_info *info) 
out_rtnl:

	rtnl_unlock();

out_dev_put:

	dev_put(dev);

	ethnl_parse_header_dev_put(&req_info);

	return ret;

}
@@ -353,7 +353,7 @@ int ethnl_act_cable_test_tdr(struct sk_buff *skb, struct genl_info *info) 
out_rtnl:

	rtnl_unlock();

out_dev_put:

	dev_put(dev);

	ethnl_parse_header_dev_put(&req_info);

	return ret;

}

net/ethtool/channels.c

+1 −1
Original line number Diff line number Diff line
@@ -219,6 +219,6 @@ int ethnl_set_channels(struct sk_buff *skb, struct genl_info *info) 
out_rtnl:

	rtnl_unlock();

out_dev:

	dev_put(dev);

	ethnl_parse_header_dev_put(&req_info);

	return ret;

}

net/ethtool/coalesce.c

+1 −1
Original line number Diff line number Diff line
@@ -336,6 +336,6 @@ int ethnl_set_coalesce(struct sk_buff *skb, struct genl_info *info) 
out_rtnl:

	rtnl_unlock();

out_dev:

	dev_put(dev);

	ethnl_parse_header_dev_put(&req_info);

	return ret;

}

net/ethtool/debug.c

+1 −1
Original line number Diff line number Diff line
@@ -123,6 +123,6 @@ int ethnl_set_debug(struct sk_buff *skb, struct genl_info *info) 
out_rtnl:

	rtnl_unlock();

out_dev:

	dev_put(dev);

	ethnl_parse_header_dev_put(&req_info);

	return ret;

}

net/ethtool/eee.c

+1 −1
Original line number Diff line number Diff line
@@ -185,6 +185,6 @@ int ethnl_set_eee(struct sk_buff *skb, struct genl_info *info) 
out_rtnl:

	rtnl_unlock();

out_dev:

	dev_put(dev);

	ethnl_parse_header_dev_put(&req_info);

	return ret;

}