Commit 34513ada authored by Ido Schimmel's avatar Ido Schimmel Committed by Jakub Kicinski
Browse files

netdevsim: Fix hwstats debugfs file permissions 



The hwstats debugfs files are only writeable, but they are created with
read and write permissions, causing certain selftests to fail [1].

Fix by creating the files with write permission only.

[1]
 # ./test_offload.py
 Test destruction of generic XDP...
 Traceback (most recent call last):
   File "/home/idosch/code/linux/tools/testing/selftests/bpf/./test_offload.py", line 810, in <module>
     simdev = NetdevSimDev()
 [...]
 Exception: Command failed: cat /sys/kernel/debug/netdevsim/netdevsim0//ports/0/dev/hwstats/l3/disable_ifindex

 cat: /sys/kernel/debug/netdevsim/netdevsim0//ports/0/dev/hwstats/l3/disable_ifindex: Invalid argument

Fixes: 1a6d7ae7 ("netdevsim: Introduce support for L3 offload xstats")
Reported-by: default avatarJie2x Zhou <jie2x.zhou@intel.com>
Tested-by: default avatarJie2x Zhou <jie2x.zhou@intel.com>
Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
Link: https://lore.kernel.org/r/20220909153830.3732504-1-idosch@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 182447b1

drivers/net/netdevsim/hwstats.c

+3 −3
Original line number Diff line number Diff line
@@ -433,11 +433,11 @@ int nsim_dev_hwstats_init(struct nsim_dev *nsim_dev) 
		goto err_remove_hwstats_recursive;

	}



	debugfs_create_file("enable_ifindex", 0600, hwstats->l3_ddir, hwstats,

	debugfs_create_file("enable_ifindex", 0200, hwstats->l3_ddir, hwstats,

			    &nsim_dev_hwstats_l3_enable_fops.fops);

	debugfs_create_file("disable_ifindex", 0600, hwstats->l3_ddir, hwstats,

	debugfs_create_file("disable_ifindex", 0200, hwstats->l3_ddir, hwstats,

			    &nsim_dev_hwstats_l3_disable_fops.fops);

	debugfs_create_file("fail_next_enable", 0600, hwstats->l3_ddir, hwstats,

	debugfs_create_file("fail_next_enable", 0200, hwstats->l3_ddir, hwstats,

			    &nsim_dev_hwstats_l3_fail_fops.fops);



	INIT_DELAYED_WORK(&hwstats->traffic_dw,