Commit 342b3a63 authored Oct 31, 2024 by Alex Hung Committed by Gu Bowen Oct 31, 2024

drm/amd/display: Check stream before comparing them

stable inclusion
from stable-v6.6.55
commit 42d31a33643813cce55ee1ebbad3a2d0d24a08e0
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/IAYR9N
CVE: CVE-2024-49896

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=42d31a33643813cce55ee1ebbad3a2d0d24a08e0



--------------------------------

[ Upstream commit 35ff747c86767937ee1e0ca987545b7eed7a0810 ]

[WHAT & HOW]
amdgpu_dm can pass a null stream to dc_is_stream_unchanged. It is
necessary to check for null before dereferencing them.

This fixes 1 FORWARD_NULL issue reported by Coverity.

Reviewed-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com>
Signed-off-by: Jerry Zuo <jerry.zuo@amd.com>
Signed-off-by: Alex Hung <alex.hung@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Gu Bowen <gubowen5@huawei.com>

parent 04bcd1e6

drivers/gpu/drm/amd/display/dc/core/dc_resource.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -2154,6 +2154,8 @@ static bool are_stream_backends_same(
		bool dc_is_stream_unchanged(
		struct dc_stream_state old_stream, struct dc_stream_state stream)
		{
		if (!old_stream \|\| !stream)
		return false;

		if (!are_stream_backends_same(old_stream, stream))
		return false;