Commit 342a67f0 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

NFS: Label the dentry with a verifier in nfs_link(), nfs_symlink() 



After the success of an operation such as link(), or symlink(), we
expect to add the dentry back to the dcache as an ordinary positive
dentry.
However in NFS, unless it is labelled with the appropriate verifier for
the parent directory state, then nfs_lookup_revalidate will end up
discarding that dentry and forcing a new lookup.

The fix is to ensure that we relabel the dentry appropriately on
success.

Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parent 9e1ff307

fs/nfs/dir.c

+3 −0
Original line number Diff line number Diff line
@@ -2352,6 +2352,8 @@ int nfs_symlink(struct user_namespace *mnt_userns, struct inode *dir, 
		return error;

	}



	nfs_set_verifier(dentry, nfs_save_change_attribute(dir));



	/*

	 * No big deal if we can't add this page to the page cache here.

	 * READLINK will get the missing page from the server if needed.
@@ -2385,6 +2387,7 @@ nfs_link(struct dentry *old_dentry, struct inode *dir, struct dentry *dentry) 
	d_drop(dentry);

	error = NFS_PROTO(dir)->link(inode, dir, &dentry->d_name);

	if (error == 0) {

		nfs_set_verifier(dentry, nfs_save_change_attribute(dir));

		ihold(inode);

		d_add(dentry, inode);

	}