Commit 3407d826 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

firmware: edd: remove empty default_attrs array 

The default_attrs array of attributes for the edd sysfs entries is
totally empty for some reason, and a list of attributes is added later
after the object is created (which should be fixed up later as it's
racy).  Because this pointer is never used, and is empty, and we are
trying to remove all default_attrs usages, just delete it.

Link: https://lore.kernel.org/r/20220105182634.2802684-1-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ab6d0f57

drivers/firmware/edd.c

+0 −9
Original line number Original line Diff line number Diff line
@@ -574,14 +574,6 @@ static EDD_DEVICE_ATTR(interface, 0444, edd_show_interface, edd_has_edd30); 
static EDD_DEVICE_ATTR(host_bus, 0444, edd_show_host_bus, edd_has_edd30);

static EDD_DEVICE_ATTR(host_bus, 0444, edd_show_host_bus, edd_has_edd30);

static EDD_DEVICE_ATTR(mbr_signature, 0444, edd_show_mbr_signature, edd_has_mbr_signature);

static EDD_DEVICE_ATTR(mbr_signature, 0444, edd_show_mbr_signature, edd_has_mbr_signature);







/* These are default attributes that are added for every edd

 * device discovered.  There are none.

 */

static struct attribute * def_attrs[] = {

	NULL,

};



/* These attributes are conditional and only added for some devices. */

/* These attributes are conditional and only added for some devices. */

static struct edd_attribute * edd_attrs[] = {

static struct edd_attribute * edd_attrs[] = {

	&edd_attr_raw_data,

	&edd_attr_raw_data,
@@ -619,7 +611,6 @@ static void edd_release(struct kobject * kobj) 
static struct kobj_type edd_ktype = {

static struct kobj_type edd_ktype = {

	.release	= edd_release,

	.release	= edd_release,

	.sysfs_ops	= &edd_attr_ops,

	.sysfs_ops	= &edd_attr_ops,

	.default_attrs	= def_attrs,

};

};





static struct kset *edd_kset;

static struct kset *edd_kset;