Commit 34009bff authored by Jacopo Mondi's avatar Jacopo Mondi Committed by Mauro Carvalho Chehab
Browse files

media: i2c: Add RDACM20 driver 



The RDACM20 is a GMSL camera supporting 1280x800 resolution images
developed by IMI based on an Omnivision 10635 sensor and a Maxim MAX9271
GMSL serializer.

The GMSL link carries power, control (I2C) and video data over a
single coax cable.

Signed-off-by: default avatarJacopo Mondi <jacopo+renesas@jmondi.org>
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: default avatarNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: default avatarKieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent e9f81768

MAINTAINERS

+12 −0
Original line number Diff line number Diff line
@@ -14412,6 +14412,18 @@ S: Supported 
T:	git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev

F:	tools/testing/selftests/rcutorture









RDACM20 Camera Sensor









M:	Jacopo Mondi <jacopo+renesas@jmondi.org>









M:	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>









M:	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>









M:	Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>









L:	linux-media@vger.kernel.org









S:	Maintained









F:	Documentation/devicetree/bindings/media/i2c/imi,rdacm2x-gmsl.yaml









F:	drivers/media/i2c/rdacm20.c









F:	drivers/media/i2c/max9271.c









F:	drivers/media/i2c/max9271.h

















RDC R-321X SoC









M:	Florian Fainelli <florian@openwrt.org>









S:	Maintained
































drivers/media/i2c/Kconfig



+13
−0






























Original line number
Diff line number
Diff line







@@ -1171,6 +1171,19 @@ config VIDEO_NOON010PC30

















source "drivers/media/i2c/m5mols/Kconfig"



















config VIDEO_RDACM20









	tristate "IMI RDACM20 camera support"









	depends on I2C









	select V4L2_FWNODE









	select VIDEO_V4L2_SUBDEV_API









	select MEDIA_CONTROLLER









	help









	  This driver supports the IMI RDACM20 GMSL camera, used in









	  ADAS systems.



















	  This camera should be used in conjunction with a GMSL









	  deserialiser such as the MAX9286.



















config VIDEO_RJ54N1









	tristate "Sharp RJ54N1CB0C sensor support"









	depends on I2C && VIDEO_V4L2
































drivers/media/i2c/Makefile



+2
−0






























Original line number
Diff line number
Diff line







@@ -120,6 +120,8 @@ obj-$(CONFIG_VIDEO_IMX290)	+= imx290.o







obj-$(CONFIG_VIDEO_IMX319)	+= imx319.o









obj-$(CONFIG_VIDEO_IMX355)	+= imx355.o









obj-$(CONFIG_VIDEO_MAX9286)	+= max9286.o









rdacm20-camera_module-objs	:= rdacm20.o max9271.o









obj-$(CONFIG_VIDEO_RDACM20)	+= rdacm20-camera_module.o









obj-$(CONFIG_VIDEO_ST_MIPID02) += st-mipid02.o



















obj-$(CONFIG_SDR_MAX2175) += max2175.o
























drivers/media/i2c/max9271.c
0 → 100644



+341
−0






























Original line number
Diff line number
Diff line









// SPDX-License-Identifier: GPL-2.0+









/*









 * Copyright (C) 2017-2020 Jacopo Mondi









 * Copyright (C) 2017-2020 Kieran Bingham









 * Copyright (C) 2017-2020 Laurent Pinchart









 * Copyright (C) 2017-2020 Niklas Söderlund









 * Copyright (C) 2016 Renesas Electronics Corporation









 * Copyright (C) 2015 Cogent Embedded, Inc.









 *









 * This file exports functions to control the Maxim MAX9271 GMSL serializer









 * chip. This is not a self-contained driver, as MAX9271 is usually embedded in









 * camera modules with at least one image sensor and optional additional









 * components, such as uController units or ISPs/DSPs.









 *









 * Drivers for the camera modules (i.e. rdacm20/21) are expected to use









 * functions exported from this library driver to maximize code re-use.









 */



















#include <linux/delay.h>









#include <linux/i2c.h>



















#include "max9271.h"



















static int max9271_read(struct max9271_device *dev, u8 reg)









{









	int ret;



















	dev_dbg(&dev->client->dev, "%s(0x%02x)\n", __func__, reg);



















	ret = i2c_smbus_read_byte_data(dev->client, reg);









	if (ret < 0)









		dev_dbg(&dev->client->dev,









			"%s: register 0x%02x read failed (%d)\n",









			__func__, reg, ret);



















	return ret;









}



















static int max9271_write(struct max9271_device *dev, u8 reg, u8 val)









{









	int ret;



















	dev_dbg(&dev->client->dev, "%s(0x%02x, 0x%02x)\n", __func__, reg, val);



















	ret = i2c_smbus_write_byte_data(dev->client, reg, val);









	if (ret < 0)









		dev_err(&dev->client->dev,









			"%s: register 0x%02x write failed (%d)\n",









			__func__, reg, ret);



















	return ret;









}



















/*









 * max9271_pclk_detect() - Detect valid pixel clock from image sensor









 *









 * Wait up to 10ms for a valid pixel clock.









 *









 * Returns 0 for success, < 0 for pixel clock not properly detected









 */









static int max9271_pclk_detect(struct max9271_device *dev)









{









	unsigned int i;









	int ret;



















	for (i = 0; i < 100; i++) {









		ret = max9271_read(dev, 0x15);









		if (ret < 0)









			return ret;



















		if (ret & MAX9271_PCLKDET)









			return 0;



















		usleep_range(50, 100);









	}



















	dev_err(&dev->client->dev, "Unable to detect valid pixel clock\n");



















	return -EIO;









}



















int max9271_set_serial_link(struct max9271_device *dev, bool enable)









{









	int ret;









	u8 val = MAX9271_REVCCEN | MAX9271_FWDCCEN;



















	if (enable) {









		ret = max9271_pclk_detect(dev);









		if (ret)









			return ret;



















		val |= MAX9271_SEREN;









	} else {









		val |= MAX9271_CLINKEN;









	}



















	/*









	 * The serializer temporarily disables the reverse control channel for









	 * 350µs after starting/stopping the forward serial link, but the









	 * deserializer synchronization time isn't clearly documented.









	 *









	 * According to the serializer datasheet we should wait 3ms, while









	 * according to the deserializer datasheet we should wait 5ms.









	 *









	 * Short delays here appear to show bit-errors in the writes following.









	 * Therefore a conservative delay seems best here.









	 */









	max9271_write(dev, 0x04, val);









	usleep_range(5000, 8000);



















	return 0;









}









EXPORT_SYMBOL_GPL(max9271_set_serial_link);



















int max9271_configure_i2c(struct max9271_device *dev, u8 i2c_config)









{









	int ret;



















	ret = max9271_write(dev, 0x0d, i2c_config);









	if (ret)









		return ret;



















	/* The delay required after an I2C bus configuration change is not









	 * characterized in the serializer manual. Sleep up to 5msec to









	 * stay safe.









	 */









	usleep_range(3500, 5000);



















	return 0;









}









EXPORT_SYMBOL_GPL(max9271_configure_i2c);



















int max9271_set_high_threshold(struct max9271_device *dev, bool enable)









{









	int ret;



















	ret = max9271_read(dev, 0x08);









	if (ret < 0)









		return ret;



















	/*









	 * Enable or disable reverse channel high threshold to increase









	 * immunity to power supply noise.









	 */









	max9271_write(dev, 0x08, enable ? ret | BIT(0) : ret & ~BIT(0));









	usleep_range(2000, 2500);



















	return 0;









}









EXPORT_SYMBOL_GPL(max9271_set_high_threshold);



















int max9271_configure_gmsl_link(struct max9271_device *dev)









{









	/*









	 * Configure the GMSL link:









	 *









	 * - Double input mode, high data rate, 24-bit mode









	 * - Latch input data on PCLKIN rising edge









	 * - Enable HS/VS encoding









	 * - 1-bit parity error detection









	 *









	 * TODO: Make the GMSL link configuration parametric.









	 */









	max9271_write(dev, 0x07, MAX9271_DBL | MAX9271_HVEN |









		      MAX9271_EDC_1BIT_PARITY);









	usleep_range(5000, 8000);



















	/*









	 * Adjust spread spectrum to +4% and auto-detect pixel clock









	 * and serial link rate.









	 */









	max9271_write(dev, 0x02, MAX9271_SPREAD_SPECT_4 | MAX9271_R02_RES |









		      MAX9271_PCLK_AUTODETECT | MAX9271_SERIAL_AUTODETECT);









	usleep_range(5000, 8000);



















	return 0;









}









EXPORT_SYMBOL_GPL(max9271_configure_gmsl_link);



















int max9271_set_gpios(struct max9271_device *dev, u8 gpio_mask)









{









	int ret;



















	ret = max9271_read(dev, 0x0f);









	if (ret < 0)









		return 0;



















	ret |= gpio_mask;









	ret = max9271_write(dev, 0x0f, ret);









	if (ret < 0) {









		dev_err(&dev->client->dev, "Failed to set gpio (%d)\n", ret);









		return ret;









	}



















	usleep_range(3500, 5000);



















	return 0;









}









EXPORT_SYMBOL_GPL(max9271_set_gpios);



















int max9271_clear_gpios(struct max9271_device *dev, u8 gpio_mask)









{









	int ret;



















	ret = max9271_read(dev, 0x0f);









	if (ret < 0)









		return 0;



















	ret &= ~gpio_mask;









	ret = max9271_write(dev, 0x0f, ret);









	if (ret < 0) {









		dev_err(&dev->client->dev, "Failed to clear gpio (%d)\n", ret);









		return ret;









	}



















	usleep_range(3500, 5000);



















	return 0;









}









EXPORT_SYMBOL_GPL(max9271_clear_gpios);



















int max9271_enable_gpios(struct max9271_device *dev, u8 gpio_mask)









{









	int ret;



















	ret = max9271_read(dev, 0x0f);









	if (ret < 0)









		return 0;



















	/* BIT(0) reserved: GPO is always enabled. */









	ret |= gpio_mask | BIT(0);









	ret = max9271_write(dev, 0x0e, ret);









	if (ret < 0) {









		dev_err(&dev->client->dev, "Failed to enable gpio (%d)\n", ret);









		return ret;









	}



















	usleep_range(3500, 5000);



















	return 0;









}









EXPORT_SYMBOL_GPL(max9271_enable_gpios);



















int max9271_disable_gpios(struct max9271_device *dev, u8 gpio_mask)









{









	int ret;



















	ret = max9271_read(dev, 0x0f);









	if (ret < 0)









		return 0;



















	/* BIT(0) reserved: GPO cannot be disabled */









	ret &= (~gpio_mask | BIT(0));









	ret = max9271_write(dev, 0x0e, ret);









	if (ret < 0) {









		dev_err(&dev->client->dev, "Failed to disable gpio (%d)\n", ret);









		return ret;









	}



















	usleep_range(3500, 5000);



















	return 0;









}









EXPORT_SYMBOL_GPL(max9271_disable_gpios);



















int max9271_verify_id(struct max9271_device *dev)









{









	int ret;



















	ret = max9271_read(dev, 0x1e);









	if (ret < 0) {









		dev_err(&dev->client->dev, "MAX9271 ID read failed (%d)\n",









			ret);









		return ret;









	}



















	if (ret != MAX9271_ID) {









		dev_err(&dev->client->dev, "MAX9271 ID mismatch (0x%02x)\n",









			ret);









		return -ENXIO;









	}



















	return 0;









}









EXPORT_SYMBOL_GPL(max9271_verify_id);



















int max9271_set_address(struct max9271_device *dev, u8 addr)









{









	int ret;



















	ret = max9271_write(dev, 0x00, addr << 1);









	if (ret < 0) {









		dev_err(&dev->client->dev,









			"MAX9271 I2C address change failed (%d)\n", ret);









		return ret;









	}









	usleep_range(3500, 5000);



















	return 0;









}









EXPORT_SYMBOL_GPL(max9271_set_address);



















int max9271_set_deserializer_address(struct max9271_device *dev, u8 addr)









{









	int ret;



















	ret = max9271_write(dev, 0x01, addr << 1);









	if (ret < 0) {









		dev_err(&dev->client->dev,









			"MAX9271 deserializer address set failed (%d)\n", ret);









		return ret;









	}









	usleep_range(3500, 5000);



















	return 0;









}









EXPORT_SYMBOL_GPL(max9271_set_deserializer_address);



















int max9271_set_translation(struct max9271_device *dev, u8 source, u8 dest)









{









	int ret;



















	ret = max9271_write(dev, 0x09, source << 1);









	if (ret < 0) {









		dev_err(&dev->client->dev,









			"MAX9271 I2C translation setup failed (%d)\n", ret);









		return ret;









	}









	usleep_range(3500, 5000);



















	ret = max9271_write(dev, 0x0a, dest << 1);









	if (ret < 0) {









		dev_err(&dev->client->dev,









			"MAX9271 I2C translation setup failed (%d)\n", ret);









		return ret;









	}









	usleep_range(3500, 5000);



















	return 0;









}









EXPORT_SYMBOL_GPL(max9271_set_translation);
























drivers/media/i2c/max9271.h
0 → 100644



+224
−0






























Original line number
Diff line number
Diff line









/* SPDX-License-Identifier: GPL-2.0+ */









/*









 * Copyright (C) 2017-2020 Jacopo Mondi









 * Copyright (C) 2017-2020 Kieran Bingham









 * Copyright (C) 2017-2020 Laurent Pinchart









 * Copyright (C) 2017-2020 Niklas Söderlund









 * Copyright (C) 2016 Renesas Electronics Corporation









 * Copyright (C) 2015 Cogent Embedded, Inc.









 */



















#include <linux/i2c.h>



















#define MAX9271_DEFAULT_ADDR	0x40



















/* Register 0x02 */









#define MAX9271_SPREAD_SPECT_0		(0 << 5)









#define MAX9271_SPREAD_SPECT_05		(1 << 5)









#define MAX9271_SPREAD_SPECT_15		(2 << 5)









#define MAX9271_SPREAD_SPECT_1		(5 << 5)









#define MAX9271_SPREAD_SPECT_2		(3 << 5)









#define MAX9271_SPREAD_SPECT_3		(6 << 5)









#define MAX9271_SPREAD_SPECT_4		(7 << 5)









#define MAX9271_R02_RES			BIT(4)









#define MAX9271_PCLK_AUTODETECT		(3 << 2)









#define MAX9271_SERIAL_AUTODETECT	(0x03)









/* Register 0x04 */









#define MAX9271_SEREN			BIT(7)









#define MAX9271_CLINKEN			BIT(6)









#define MAX9271_PRBSEN			BIT(5)









#define MAX9271_SLEEP			BIT(4)









#define MAX9271_INTTYPE_I2C		(0 << 2)









#define MAX9271_INTTYPE_UART		(1 << 2)









#define MAX9271_INTTYPE_NONE		(2 << 2)









#define MAX9271_REVCCEN			BIT(1)









#define MAX9271_FWDCCEN			BIT(0)









/* Register 0x07 */









#define MAX9271_DBL			BIT(7)









#define MAX9271_DRS			BIT(6)









#define MAX9271_BWS			BIT(5)









#define MAX9271_ES			BIT(4)









#define MAX9271_HVEN			BIT(2)









#define MAX9271_EDC_1BIT_PARITY		(0 << 0)









#define MAX9271_EDC_6BIT_CRC		(1 << 0)









#define MAX9271_EDC_6BIT_HAMMING	(2 << 0)









/* Register 0x08 */









#define MAX9271_INVVS			BIT(7)









#define MAX9271_INVHS			BIT(6)









#define MAX9271_REV_LOGAIN		BIT(3)









#define MAX9271_REV_HIVTH		BIT(0)









/* Register 0x09 */









#define MAX9271_ID			0x09









/* Register 0x0d */









#define MAX9271_I2CLOCACK		BIT(7)









#define MAX9271_I2CSLVSH_1046NS_469NS	(3 << 5)









#define MAX9271_I2CSLVSH_938NS_352NS	(2 << 5)









#define MAX9271_I2CSLVSH_469NS_234NS	(1 << 5)









#define MAX9271_I2CSLVSH_352NS_117NS	(0 << 5)









#define MAX9271_I2CMSTBT_837KBPS	(7 << 2)









#define MAX9271_I2CMSTBT_533KBPS	(6 << 2)









#define MAX9271_I2CMSTBT_339KBPS	(5 << 2)









#define MAX9271_I2CMSTBT_173KBPS	(4 << 2)









#define MAX9271_I2CMSTBT_105KBPS	(3 << 2)









#define MAX9271_I2CMSTBT_84KBPS		(2 << 2)









#define MAX9271_I2CMSTBT_28KBPS		(1 << 2)









#define MAX9271_I2CMSTBT_8KBPS		(0 << 2)









#define MAX9271_I2CSLVTO_NONE		(3 << 0)









#define MAX9271_I2CSLVTO_1024US		(2 << 0)









#define MAX9271_I2CSLVTO_256US		(1 << 0)









#define MAX9271_I2CSLVTO_64US		(0 << 0)









/* Register 0x0f */









#define MAX9271_GPIO5OUT		BIT(5)









#define MAX9271_GPIO4OUT		BIT(4)









#define MAX9271_GPIO3OUT		BIT(3)









#define MAX9271_GPIO2OUT		BIT(2)









#define MAX9271_GPIO1OUT		BIT(1)









#define MAX9271_GPO			BIT(0)









/* Register 0x15 */









#define MAX9271_PCLKDET			BIT(0)



















/**









 * struct max9271_device - max9271 device









 * @client: The i2c client for the max9271 instance









 */









struct max9271_device {









	struct i2c_client *client;









};



















/**









 * max9271_set_serial_link() - Enable/disable serial link









 * @dev: The max9271 device









 * @enable: Serial link enable/disable flag









 *









 * Return 0 on success or a negative error code on failure









 */









int max9271_set_serial_link(struct max9271_device *dev, bool enable);



















/**









 * max9271_configure_i2c() - Configure I2C bus parameters









 * @dev: The max9271 device









 * @i2c_config: The I2C bus configuration bit mask









 *









 * Configure MAX9271 I2C interface. The bus configuration provided in the









 * @i2c_config parameter shall be assembled using bit values defined by the









 * MAX9271_I2C* macros.









 *









 * Return 0 on success or a negative error code on failure









 */









int max9271_configure_i2c(struct max9271_device *dev, u8 i2c_config);



















/**









 * max9271_set_high_threshold() - Enable or disable reverse channel high









 *				  threshold









 * @dev: The max9271 device









 * @enable: High threshold enable/disable flag









 *









 * Return 0 on success or a negative error code on failure









 */









int max9271_set_high_threshold(struct max9271_device *dev, bool enable);



















/**









 * max9271_configure_gmsl_link() - Configure the GMSL link









 * @dev: The max9271 device









 *









 * FIXME: the GMSL link configuration is currently hardcoded and performed









 * by programming registers 0x04, 0x07 and 0x02.









 *









 * Return 0 on success or a negative error code on failure









 */









int max9271_configure_gmsl_link(struct max9271_device *dev);



















/**









 * max9271_set_gpios() - Set gpio lines to physical high value









 * @dev: The max9271 device









 * @gpio_mask: The mask of gpio lines to set to high value









 *









 * The @gpio_mask parameter shall be assembled using the MAX9271_GP[IO|O]*









 * bit values.









 *









 * Return 0 on success or a negative error code on failure









 */









int max9271_set_gpios(struct max9271_device *dev, u8 gpio_mask);



















/**









 * max9271_clear_gpios() - Set gpio lines to physical low value









 * @dev: The max9271 device









 * @gpio_mask: The mask of gpio lines to set to low value









 *









 * The @gpio_mask parameter shall be assembled using the MAX9271_GP[IO|O]*









 * bit values.









 *









 * Return 0 on success or a negative error code on failure









 */









int max9271_clear_gpios(struct max9271_device *dev, u8 gpio_mask);



















/**









 * max9271_enable_gpios() - Enable gpio lines









 * @dev: The max9271 device









 * @gpio_mask: The mask of gpio lines to enable









 *









 * The @gpio_mask parameter shall be assembled using the MAX9271_GPIO*









 * bit values. GPO line is always enabled by default.









 *









 * Return 0 on success or a negative error code on failure









 */









int max9271_enable_gpios(struct max9271_device *dev, u8 gpio_mask);



















/**









 * max9271_disable_gpios() - Disable gpio lines









 * @dev: The max9271 device









 * @gpio_mask: The mask of gpio lines to disable









 *









 * The @gpio_mask parameter shall be assembled using the MAX9271_GPIO*









 * bit values. GPO line is always enabled by default and cannot be disabled.









 *









 * Return 0 on success or a negative error code on failure









 */









int max9271_disable_gpios(struct max9271_device *dev, u8 gpio_mask);



















/**









 * max9271_verify_id() - Read and verify MAX9271 id









 * @dev: The max9271 device









 *









 * Return 0 on success or a negative error code on failure









 */









int max9271_verify_id(struct max9271_device *dev);



















/**









 * max9271_set_address() - Program a new I2C address









 * @dev: The max9271 device









 * @addr: The new I2C address in 7-bit format









 *









 * This function only takes care of programming the new I2C address @addr to









 * in the MAX9271 chip registers, it is responsiblity of the caller to set









 * the i2c address client to the @addr value to be able to communicate with









 * the MAX9271 chip using the I2C framework APIs after this function returns.









 *









 * Return 0 on success or a negative error code on failure









 */









int max9271_set_address(struct max9271_device *dev, u8 addr);



















/**









 * max9271_set_deserializer_address() - Program the remote deserializer address









 * @dev: The max9271 device









 * @addr: The deserializer I2C address in 7-bit format









 *









 * Return 0 on success or a negative error code on failure









 */









int max9271_set_deserializer_address(struct max9271_device *dev, u8 addr);



















/**









 * max9271_set_translation() - Program I2C address translation









 * @dev: The max9271 device









 * @source: The I2C source address









 * @dest: The I2C destination address









 *









 * Program address translation from @source to @dest. This is required to









 * communicate with local devices that do not support address reprogramming.









 *









 * TODO: The device supports translation of two address, this function currently









 * supports a single one.









 *









 * Return 0 on success or a negative error code on failure









 */









int max9271_set_translation(struct max9271_device *dev, u8 source, u8 dest);