Commit 33fbe6be authored by Maxim Levitsky's avatar Maxim Levitsky Committed by Paolo Bonzini
Browse files

KVM: x86: fix typo in __try_cmpxchg_user causing non-atomicness 



This shows up as a TDP MMU leak when running nested.  Non-working cmpxchg on L0
relies makes L1 install two different shadow pages under same spte, and one of
them is leaked.

Fixes: 1c2361f6 ("KVM: x86: Use __try_cmpxchg_user() to emulate atomic accesses")
Signed-off-by: default avatarMaxim Levitsky <mlevitsk@redhat.com>
Message-Id: <20220512101420.306759-1-mlevitsk@redhat.com>
Reviewed-by: default avatarSean Christopherson <seanjc@google.com>
Reviewed-by: default avatarVitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 99132883

arch/x86/kvm/x86.c

+1 −1
Original line number Diff line number Diff line
@@ -7315,7 +7315,7 @@ static int emulator_cmpxchg_emulated(struct x86_emulate_ctxt *ctxt, 
		goto emul_write;



	hva = kvm_vcpu_gfn_to_hva(vcpu, gpa_to_gfn(gpa));

	if (kvm_is_error_hva(addr))

	if (kvm_is_error_hva(hva))

		goto emul_write;



	hva += offset_in_page(gpa);