Commit 33ccec5f authored by Dan Carpenter's avatar Dan Carpenter Committed by Daniel Borkmann
Browse files

bpf: Fix a warning message in mark_ptr_not_null_reg() 



The WARN_ON() argument is a condition, not an error message.  So this
code will print a stack trace but will not print the warning message.
Fix that and also change it to only WARN_ONCE().

Fixes: 4ddb7416 ("bpf: Extract nullable reg type conversion into a helper function")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/YCzJlV3hnF%2Ft1Pk4@mwanda
parent b29dd96b

kernel/bpf/verifier.c

+1 −1
Original line number Diff line number Diff line
@@ -1120,7 +1120,7 @@ static void mark_ptr_not_null_reg(struct bpf_reg_state *reg) 
		reg->type = PTR_TO_RDWR_BUF;

		break;

	default:

		WARN_ON("unknown nullable register type");

		WARN_ONCE(1, "unknown nullable register type");

	}

}