Commit 33c6a549 authored by Wang Kefeng's avatar Wang Kefeng Committed by Russell King (Oracle)
Browse files

ARM: 9162/1: amba: Kill sysfs attribute file of irq 

As Rob said[1], there doesn't seem to be any users about the sysfs
attribute file of irq[0] and irq[1]. And we don't need to include
<asm/irq.h> as NO_IRQ has gone. Let's kill both of them.

[1] https://lkml.org/lkml/2021/8/25/461



Acked-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarKefeng Wang <wangkefeng.wang@huawei.com>
Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
parent d0eae828

drivers/amba/bus.c

+2 −17
Original line number Diff line number Diff line
@@ -21,8 +21,6 @@ 
#include <linux/reset.h>

#include <linux/of_irq.h>



#include <asm/irq.h>



#define to_amba_driver(d)	container_of(d, struct amba_driver, drv)



/* called on periphid match and class 0x9 coresight device. */
@@ -136,8 +134,6 @@ static ssize_t name##_show(struct device *_dev, \ 
static DEVICE_ATTR_RO(name)



amba_attr_func(id, "%08x\n", dev->periphid);

amba_attr_func(irq0, "%u\n", dev->irq[0]);

amba_attr_func(irq1, "%u\n", dev->irq[1]);

amba_attr_func(resource, "\t%016llx\t%016llx\t%016lx\n",

	 (unsigned long long)dev->res.start, (unsigned long long)dev->res.end,

	 dev->res.flags);
@@ -488,19 +484,8 @@ static int amba_device_try_add(struct amba_device *dev, struct resource *parent) 


 skip_probe:

	ret = device_add(&dev->dev);

	if (ret)

		goto err_release;



	if (dev->irq[0])

		ret = device_create_file(&dev->dev, &dev_attr_irq0);

	if (ret == 0 && dev->irq[1])

		ret = device_create_file(&dev->dev, &dev_attr_irq1);

	if (ret == 0)

		return ret;



	device_unregister(&dev->dev);



 err_release:

	if (ret)

		release_resource(&dev->res);

 err_out:

	return ret;