Commit 339db11b authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

net/llc: make opt unsigned in llc_ui_setsockopt() 



The members of struct llc_sock are unsigned so if we pass a negative
value for "opt" it can cause a sign bug.  Also it can cause an integer
overflow when we multiply "opt * HZ".

CC: stable@kernel.org
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a505b3b3

net/llc/af_llc.c

+2 −1
Original line number Diff line number Diff line
@@ -1024,7 +1024,8 @@ static int llc_ui_setsockopt(struct socket *sock, int level, int optname, 
{

	struct sock *sk = sock->sk;

	struct llc_sock *llc = llc_sk(sk);

	int rc = -EINVAL, opt;

	unsigned int opt;

	int rc = -EINVAL;



	lock_sock(sk);

	if (unlikely(level != SOL_LLC || optlen != sizeof(int)))