Commit 33786a28 authored by Heikki Krogerus's avatar Heikki Krogerus Committed by Greg Kroah-Hartman
Browse files

usb: typec: ucsi: Fix the notification bit offsets 



The bit offsets for the Set Notification Enable command were
not considering the reserved bits in the middle.

Fixes: 470ce43a ("usb: typec: ucsi: Remove struct ucsi_control")
Signed-off-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20200108131347.43217-2-heikki.krogerus@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2548288b

drivers/usb/typec/ucsi/ucsi.h

+9 −9
Original line number Diff line number Diff line
@@ -94,15 +94,15 @@ void ucsi_connector_change(struct ucsi *ucsi, u8 num); 
#define UCSI_ENABLE_NTFY_CMD_COMPLETE		BIT(16)

#define UCSI_ENABLE_NTFY_EXT_PWR_SRC_CHANGE	BIT(17)

#define UCSI_ENABLE_NTFY_PWR_OPMODE_CHANGE	BIT(18)

#define UCSI_ENABLE_NTFY_CAP_CHANGE		BIT(19)

#define UCSI_ENABLE_NTFY_PWR_LEVEL_CHANGE	BIT(20)

#define UCSI_ENABLE_NTFY_PD_RESET_COMPLETE	BIT(21)

#define UCSI_ENABLE_NTFY_CAM_CHANGE		BIT(22)

#define UCSI_ENABLE_NTFY_BAT_STATUS_CHANGE	BIT(23)

#define UCSI_ENABLE_NTFY_PARTNER_CHANGE		BIT(24)

#define UCSI_ENABLE_NTFY_PWR_DIR_CHANGE		BIT(25)

#define UCSI_ENABLE_NTFY_CONNECTOR_CHANGE	BIT(26)

#define UCSI_ENABLE_NTFY_ERROR			BIT(27)

#define UCSI_ENABLE_NTFY_CAP_CHANGE		BIT(21)

#define UCSI_ENABLE_NTFY_PWR_LEVEL_CHANGE	BIT(22)

#define UCSI_ENABLE_NTFY_PD_RESET_COMPLETE	BIT(23)

#define UCSI_ENABLE_NTFY_CAM_CHANGE		BIT(24)

#define UCSI_ENABLE_NTFY_BAT_STATUS_CHANGE	BIT(25)

#define UCSI_ENABLE_NTFY_PARTNER_CHANGE		BIT(27)

#define UCSI_ENABLE_NTFY_PWR_DIR_CHANGE		BIT(28)

#define UCSI_ENABLE_NTFY_CONNECTOR_CHANGE	BIT(30)

#define UCSI_ENABLE_NTFY_ERROR			BIT(31)

#define UCSI_ENABLE_NTFY_ALL			0xdbe70000



/* SET_UOR command bits */