Commit 33701397 authored by Maciej Żenczykowski's avatar Maciej Żenczykowski Committed by Greg Kroah-Hartman
Browse files

USB: f_ncm: ncm_bitrate (speed) is unsigned 



[  190.544755] configfs-gadget gadget: notify speed -44967296

This is because 4250000000 - 2**32 is -44967296.

Fixes: 9f6ce424 ("usb: gadget: f_ncm.c added")
Cc: Brooke Basile <brookebasile@gmail.com>
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Lorenzo Colitti <lorenzo@google.com>
Cc: Yauheni Kaliuta <yauheni.kaliuta@nokia.com>
Cc: Linux USB Mailing List <linux-usb@vger.kernel.org>
Acked-By: default avatarLorenzo Colitti <lorenzo@google.com>
Signed-off-by: default avatarMaciej Żenczykowski <maze@google.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210608005344.3762668-1-zenczykowski@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 40d9e03f

drivers/usb/gadget/function/f_ncm.c

+1 −1
Original line number Diff line number Diff line
@@ -583,7 +583,7 @@ static void ncm_do_notify(struct f_ncm *ncm) 
		data[0] = cpu_to_le32(ncm_bitrate(cdev->gadget));

		data[1] = data[0];



		DBG(cdev, "notify speed %d\n", ncm_bitrate(cdev->gadget));

		DBG(cdev, "notify speed %u\n", ncm_bitrate(cdev->gadget));

		ncm->notify_state = NCM_NOTIFY_CONNECT;

		break;

	}