Commit 335a2a1f authored by Yang Li's avatar Yang Li Committed by Steffen Klassert
Browse files

esp: drop unneeded assignment in esp4_gro_receive() 



Making '!=' operation with 0 directly after calling
the function xfrm_parse_spi() is more efficient,
assignment to err is redundant.

Eliminate the following clang_analyzer warning:
net/ipv4/esp4_offload.c:41:7: warning: Although the value stored to
'err' is used in the enclosing expression, the value is never actually
read from 'err'

No functional change, only more efficient.

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Signed-off-by: default avatarSteffen Klassert <steffen.klassert@secunet.com>
parent ea89c862

net/ipv4/esp4_offload.c

+1 −2
Original line number Diff line number Diff line
@@ -33,12 +33,11 @@ static struct sk_buff *esp4_gro_receive(struct list_head *head, 
	struct xfrm_state *x;

	__be32 seq;

	__be32 spi;

	int err;



	if (!pskb_pull(skb, offset))

		return NULL;



	if ((err = xfrm_parse_spi(skb, IPPROTO_ESP, &spi, &seq)) != 0)

	if (xfrm_parse_spi(skb, IPPROTO_ESP, &spi, &seq) != 0)

		goto out;



	xo = xfrm_offload(skb);