Commit 333ab99e authored by Linyu Yuan's avatar Linyu Yuan Committed by Greg Kroah-Hartman
Browse files

usb: gadget: remove max support speed info in bind operation 



Take ecm_bind() for example, it call gadget_is_{*}speed() API to show
gadget max support speed, it is not much help, remove the API usage here
is safe.

Similar change apply to acm,eem,loopback,ncm,obex,rndis,serial,
sourcesink,subset functions.

Signed-off-by: default avatarLinyu Yuan <quic_linyyuan@quicinc.com>
Link: https://lore.kernel.org/r/20230803091053.9714-8-quic_linyyuan@quicinc.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent dc2e6960

drivers/usb/gadget/function/f_acm.c

+1 −3
Original line number Diff line number Diff line
@@ -691,10 +691,8 @@ acm_bind(struct usb_configuration *c, struct usb_function *f) 
		goto fail;



	dev_dbg(&cdev->gadget->dev,

		"acm ttyGS%d: %s speed IN/%s OUT/%s NOTIFY/%s\n",

		"acm ttyGS%d: IN/%s OUT/%s NOTIFY/%s\n",

		acm->port_num,

		gadget_is_superspeed(c->cdev->gadget) ? "super" :

		gadget_is_dualspeed(c->cdev->gadget) ? "dual" : "full",

		acm->port.in->name, acm->port.out->name,

		acm->notify->name);

	return 0;

drivers/usb/gadget/function/f_ecm.c

+1 −3
Original line number Diff line number Diff line
@@ -788,9 +788,7 @@ ecm_bind(struct usb_configuration *c, struct usb_function *f) 
	ecm->port.open = ecm_open;

	ecm->port.close = ecm_close;



	DBG(cdev, "CDC Ethernet: %s speed IN/%s OUT/%s NOTIFY/%s\n",

			gadget_is_superspeed(c->cdev->gadget) ? "super" :

			gadget_is_dualspeed(c->cdev->gadget) ? "dual" : "full",

	DBG(cdev, "CDC Ethernet: IN/%s OUT/%s NOTIFY/%s\n",

			ecm->port.in_ep->name, ecm->port.out_ep->name,

			ecm->notify->name);

	return 0;

drivers/usb/gadget/function/f_eem.c

+1 −3
Original line number Diff line number Diff line
@@ -311,9 +311,7 @@ static int eem_bind(struct usb_configuration *c, struct usb_function *f) 
	if (status)

		goto fail;



	DBG(cdev, "CDC Ethernet (EEM): %s speed IN/%s OUT/%s\n",

			gadget_is_superspeed(c->cdev->gadget) ? "super" :

			gadget_is_dualspeed(c->cdev->gadget) ? "dual" : "full",

	DBG(cdev, "CDC Ethernet (EEM): IN/%s OUT/%s\n",

			eem->port.in_ep->name, eem->port.out_ep->name);

	return 0;

drivers/usb/gadget/function/f_loopback.c

+1 −3
Original line number Diff line number Diff line
@@ -211,9 +211,7 @@ static int loopback_bind(struct usb_configuration *c, struct usb_function *f) 
	if (ret)

		return ret;



	DBG(cdev, "%s speed %s: IN/%s, OUT/%s\n",

	    (gadget_is_superspeed(c->cdev->gadget) ? "super" :

	     (gadget_is_dualspeed(c->cdev->gadget) ? "dual" : "full")),

	DBG(cdev, "%s: IN/%s, OUT/%s\n",

			f->name, loop->in_ep->name, loop->out_ep->name);

	return 0;

}

drivers/usb/gadget/function/f_ncm.c

+1 −3
Original line number Diff line number Diff line
@@ -1529,9 +1529,7 @@ static int ncm_bind(struct usb_configuration *c, struct usb_function *f) 
	hrtimer_init(&ncm->task_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL_SOFT);

	ncm->task_timer.function = ncm_tx_timeout;



	DBG(cdev, "CDC Network: %s speed IN/%s OUT/%s NOTIFY/%s\n",

			gadget_is_superspeed(c->cdev->gadget) ? "super" :

			gadget_is_dualspeed(c->cdev->gadget) ? "dual" : "full",

	DBG(cdev, "CDC Network: IN/%s OUT/%s NOTIFY/%s\n",

			ncm->port.in_ep->name, ncm->port.out_ep->name,

			ncm->notify->name);

	return 0;