Commit 331c6e91 authored by Borislav Petkov's avatar Borislav Petkov Committed by Martin K. Petersen
Browse files

scsi: aacraid: Fix undefined behavior due to shift overflowing the constant 

Fix:

  drivers/scsi/aacraid/commsup.c: In function ‘aac_handle_sa_aif’:
  drivers/scsi/aacraid/commsup.c:1983:2: error: case label does not reduce to an integer constant
    case SA_AIF_BPCFG_CHANGE:
    ^~~~

See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory
details as to why it triggers with older gccs only.

Link: https://lore.kernel.org/r/20220405151517.29753-2-bp@alien8.de


Cc: Adaptec OEM Raid Solutions <aacraid@microsemi.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Reviewed-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 4a5fc1c6

drivers/scsi/aacraid/aacraid.h

+1 −1
Original line number Diff line number Diff line
@@ -121,7 +121,7 @@ enum { 
#define SA_AIF_PDEV_CHANGE		(1<<4)

#define SA_AIF_LDEV_CHANGE		(1<<5)

#define SA_AIF_BPSTAT_CHANGE		(1<<30)

#define SA_AIF_BPCFG_CHANGE		(1<<31)

#define SA_AIF_BPCFG_CHANGE		(1U<<31)



#define HBA_MAX_SG_EMBEDDED		28

#define HBA_MAX_SG_SEPARATE		90