Commit 33132068 authored by Ioana Ciornei's avatar Ioana Ciornei Committed by David S. Miller
Browse files

net: dpaa2-eth: rearrange variable in dpaa2_eth_get_ethtool_stats 



Rearrange the variables in the dpaa2_eth_get_ethtool_stats() function so
that we adhere to the reverse Christmas tree rule.
Also, in the next patch we are adding more variables and I didn't know
where to place them with the current ordering.

Signed-off-by: default avatarIoana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 14e493dd

drivers/net/ethernet/freescale/dpaa2/dpaa2-ethtool.c

+8 −10
Original line number Diff line number Diff line
@@ -226,17 +226,8 @@ static void dpaa2_eth_get_ethtool_stats(struct net_device *net_dev, 
					struct ethtool_stats *stats,

					u64 *data)

{

	int i = 0;

	int j, k, err;

	int num_cnt;

	union dpni_statistics dpni_stats;

	u32 fcnt, bcnt;

	u32 fcnt_rx_total = 0, fcnt_tx_total = 0;

	u32 bcnt_rx_total = 0, bcnt_tx_total = 0;

	u32 buf_cnt;

	struct dpaa2_eth_priv *priv = netdev_priv(net_dev);

	struct dpaa2_eth_drv_stats *extras;

	struct dpaa2_eth_ch_stats *ch_stats;

	union dpni_statistics dpni_stats;

	int dpni_stats_page_size[DPNI_STATISTICS_CNT] = {

		sizeof(dpni_stats.page_0),

		sizeof(dpni_stats.page_1),
@@ -246,6 +237,13 @@ static void dpaa2_eth_get_ethtool_stats(struct net_device *net_dev, 
		sizeof(dpni_stats.page_5),

		sizeof(dpni_stats.page_6),

	};

	u32 fcnt_rx_total = 0, fcnt_tx_total = 0;

	u32 bcnt_rx_total = 0, bcnt_tx_total = 0;

	struct dpaa2_eth_ch_stats *ch_stats;

	struct dpaa2_eth_drv_stats *extras;

	int j, k, err, num_cnt, i = 0;

	u32 fcnt, bcnt;

	u32 buf_cnt;



	memset(data, 0,

	       sizeof(u64) * (DPAA2_ETH_NUM_STATS + DPAA2_ETH_NUM_EXTRA_STATS));