Commit 32f7eed0 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Wolfram Sang
Browse files

leds: lm3601x: Don't use mutex after it was destroyed 



The mutex might still be in use until the devm cleanup callback
devm_led_classdev_flash_release() is called. This only happens some time
after lm3601x_remove() completed.

Fixes: e63a7448 ("leds: lm3601x: Convert class registration to device managed")
Acked-by: default avatarPavel Machek <pavel@ucw.cz>
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent af89fa11

drivers/leds/flash/leds-lm3601x.c

+0 −2
Original line number Diff line number Diff line
@@ -444,8 +444,6 @@ static int lm3601x_remove(struct i2c_client *client) 
{

	struct lm3601x_led *led = i2c_get_clientdata(client);



	mutex_destroy(&led->lock);



	return regmap_update_bits(led->regmap, LM3601X_ENABLE_REG,

			   LM3601X_ENABLE_MASK,

			   LM3601X_MODE_STANDBY);