Commit 32e9b48d authored by Kyle Tso's avatar Kyle Tso Committed by Greg Kroah-Hartman
Browse files

usb: typec: Return void in typec_partner_set_pd_revision 



typec_partner_set_pd_revision doesn't need any return value.

Fixes: 29b01295 ("usb: typec: Add typec_partner_set_pd_revision")
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: default avatarBenson Leung <bleung@chromium.org>
Signed-off-by: default avatarKyle Tso <kyletso@google.com>
Link: https://lore.kernel.org/r/20210202095512.761214-1-kyletso@google.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2a16e18c

drivers/usb/typec/class.c

+2 −8
Original line number Diff line number Diff line
@@ -755,15 +755,11 @@ EXPORT_SYMBOL_GPL(typec_partner_set_identity); 
 *

 * This routine is used to report that the PD revision of the port partner has

 * become available.

 *

 * Returns 0 on success or negative error number on failure.

 */

int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision)

void typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision)

{

	int ret;



	if (partner->pd_revision == pd_revision)

		return 0;

		return;



	partner->pd_revision = pd_revision;

	sysfs_notify(&partner->dev.kobj, NULL, "usb_power_delivery_revision");
@@ -773,8 +769,6 @@ int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision 
			     "supports_usb_power_delivery");

	}

	kobject_uevent(&partner->dev.kobj, KOBJ_CHANGE);



	return 0;

}

EXPORT_SYMBOL_GPL(typec_partner_set_pd_revision);

include/linux/usb/typec.h

+1 −1
Original line number Diff line number Diff line
@@ -126,7 +126,7 @@ struct typec_altmode_desc { 
	enum typec_port_data	roles;

};



int typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision);

void typec_partner_set_pd_revision(struct typec_partner *partner, u16 pd_revision);

int typec_partner_set_num_altmodes(struct typec_partner *partner, int num_altmodes);

struct typec_altmode

*typec_partner_register_altmode(struct typec_partner *partner,